tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

fbdev/kyro: Use fbdev I/O helpers

Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-22-tzimmermann@suse.de

Thomas Zimmermann dfc676d0 4df6457c

+2 -6
+1 -3
drivers/video/fbdev/Kconfig
··· 1306 1306 config FB_KYRO 1307 1307 tristate "IMG Kyro support" 1308 1308 depends on FB && PCI 1309 - select FB_CFB_FILLRECT 1310 - select FB_CFB_COPYAREA 1311 - select FB_CFB_IMAGEBLIT 1309 + select FB_IOMEM_HELPERS 1312 1310 select VIDEO_NOMODESET 1313 1311 help 1314 1312 Say Y here if you have a STG4000 / Kyro / PowerVR 3 based
+1 -3
drivers/video/fbdev/kyro/fbdev.c
··· 661 661 662 662 static const struct fb_ops kyrofb_ops = { 663 663 .owner = THIS_MODULE, 664 + FB_DEFAULT_IOMEM_OPS, 664 665 .fb_check_var = kyrofb_check_var, 665 666 .fb_set_par = kyrofb_set_par, 666 667 .fb_setcolreg = kyrofb_setcolreg, 667 668 .fb_ioctl = kyrofb_ioctl, 668 - .fb_fillrect = cfb_fillrect, 669 - .fb_copyarea = cfb_copyarea, 670 - .fb_imageblit = cfb_imageblit, 671 669 }; 672 670 673 671 static int kyrofb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)