Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address

of_get_next_parent() returns a node pointer with refcount incremented,
we should use of_node_put() on it when not need anymore.
Add missing of_node_put() in the error path to avoid refcount leak.

Fixes: ce21b3c9648a ("[CELL] add support for MSI on Axon-based Cell systems")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220605065129.63906-1-linmq006@gmail.com

authored by

Miaoqian Lin and committed by
Michael Ellerman
df5d4b61 255b650c

+1
+1
arch/powerpc/platforms/cell/axon_msi.c
··· 223 223 if (!prop) { 224 224 dev_dbg(&dev->dev, 225 225 "axon_msi: no msi-address-(32|64) properties found\n"); 226 + of_node_put(dn); 226 227 return -ENOENT; 227 228 } 228 229