Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: accel: mma9551: Check gpiod_to_irq return value

The return value of gpiod_to_irq should be checked before giving
it to devm_request_threaded_irq in order to not pass an error
code in case it fails.

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Reviewed-by: Vlad Dogaru <vlad.dogaru@intel.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

authored by

Roberta Dobrescu and committed by
Jonathan Cameron
debf6d84 4a428bf3

+5 -1
+5 -1
drivers/iio/accel/mma9551.c
··· 425 425 return PTR_ERR(gpio); 426 426 } 427 427 428 - data->irqs[i] = gpiod_to_irq(gpio); 428 + ret = gpiod_to_irq(gpio); 429 + if (ret < 0) 430 + return ret; 431 + 432 + data->irqs[i] = ret; 429 433 ret = devm_request_threaded_irq(dev, data->irqs[i], 430 434 NULL, mma9551_event_handler, 431 435 IRQF_TRIGGER_RISING | IRQF_ONESHOT,