Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

wifi: rtw88: Remove duplicate NULL check before calling usb_kill/free_urb()

Both usb_kill_urb() and usb_free_urb() do the NULL check itself, so there
is no need to duplicate it prior to calling.

Fixes: a82dfd33d123 ("wifi: rtw88: Add common USB chip support")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20231008025852.1239450-1-ruanjinjie@huawei.com

authored by

Jinjie Ruan and committed by
Kalle Valo
de8dd096 71ffa1bc

+3 -6
+3 -6
drivers/net/wireless/realtek/rtw88/usb.c
··· 611 611 612 612 for (i = 0; i < RTW_USB_RXCB_NUM; i++) { 613 613 rxcb = &rtwusb->rx_cb[i]; 614 - if (rxcb->rx_urb) 615 - usb_kill_urb(rxcb->rx_urb); 614 + usb_kill_urb(rxcb->rx_urb); 616 615 } 617 616 } 618 617 ··· 622 623 623 624 for (i = 0; i < RTW_USB_RXCB_NUM; i++) { 624 625 rxcb = &rtwusb->rx_cb[i]; 625 - if (rxcb->rx_urb) { 626 - usb_kill_urb(rxcb->rx_urb); 627 - usb_free_urb(rxcb->rx_urb); 628 - } 626 + usb_kill_urb(rxcb->rx_urb); 627 + usb_free_urb(rxcb->rx_urb); 629 628 } 630 629 } 631 630