Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usbtmc: more sanity checking for packet size

A malicious device can make the driver divide ny zero
with a nonsense maximum packet size.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20190820092826.17694-1-oneukum@suse.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Oliver Neukum and committed by
Greg Kroah-Hartman
de7b9aa6 3afa758c

+3
+3
drivers/usb/class/usbtmc.c
··· 2362 2362 goto err_put; 2363 2363 } 2364 2364 2365 + retcode = -EINVAL; 2365 2366 data->bulk_in = bulk_in->bEndpointAddress; 2366 2367 data->wMaxPacketSize = usb_endpoint_maxp(bulk_in); 2368 + if (!data->wMaxPacketSize) 2369 + goto err_put; 2367 2370 dev_dbg(&intf->dev, "Found bulk in endpoint at %u\n", data->bulk_in); 2368 2371 2369 2372 data->bulk_out = bulk_out->bEndpointAddress;