Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/msm/dp: Remove aux_cfg_update_done and related code

The member 'aux_cfg_update_done' is always false. This is dead code that
never runs. Remove it.

Cc: Vinod Polimera <quic_vpolimer@quicinc.com>
Cc: Kuogee Hsieh <quic_khsieh@quicinc.com>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Tested-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
Reviewed-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/554985/
Link: https://lore.kernel.org/r/20230829184735.2841739-5-swboyd@chromium.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

authored by

Stephen Boyd and committed by
Dmitry Baryshkov
de77a733 7bfd3259

-15
-15
drivers/gpu/drm/msm/dp/dp_panel.c
··· 17 17 struct dp_link *link; 18 18 struct dp_catalog *catalog; 19 19 bool panel_on; 20 - bool aux_cfg_update_done; 21 20 }; 22 21 23 22 static void dp_panel_read_psr_cap(struct dp_panel_private *panel) ··· 176 177 } 177 178 } 178 179 179 - if (panel->aux_cfg_update_done) { 180 - drm_dbg_dp(panel->drm_dev, 181 - "read DPCD with updated AUX config\n"); 182 - rc = dp_panel_read_dpcd(dp_panel); 183 - bw_code = drm_dp_link_rate_to_bw_code(dp_panel->link_info.rate); 184 - if (rc || !is_link_rate_valid(bw_code) || 185 - !is_lane_count_valid(dp_panel->link_info.num_lanes) 186 - || (bw_code > dp_panel->max_bw_code)) { 187 - DRM_ERROR("read dpcd failed %d\n", rc); 188 - return rc; 189 - } 190 - panel->aux_cfg_update_done = false; 191 - } 192 180 end: 193 181 return rc; 194 182 } ··· 420 434 421 435 dp_panel = &panel->dp_panel; 422 436 dp_panel->max_bw_code = DP_LINK_BW_8_1; 423 - panel->aux_cfg_update_done = false; 424 437 425 438 return dp_panel; 426 439 }