Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mfd: ab8500-debugfs: Clean-up non-conforming commenting and print formatting

WARNING: Block comments use a trailing */ on a separate line
+ * not be accessed from here */

WARNING: Block comments use a trailing */ on a separate line
+ * not be accessed from here */

WARNING: Block comments use a trailing */ on a separate line
+ * the output is wanted in any case */

WARNING: Consecutive strings are generally better as a single string
+ " addr=0x%08X, mask=0x%X, shift=%d" "value=0x%X\n",

total: 0 errors, 4 warnings, 3331 lines checked

Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

Lee Jones de6a7693 500e69a1

+15 -10
+15 -10
drivers/mfd/ab8500-debugfs.c
··· 242 242 .first = 0x40, 243 243 .last = 0x44, 244 244 }, 245 - /* 0x80-0x8B is SIM registers and should 246 - * not be accessed from here */ 245 + /* 246 + * 0x80-0x8B are SIM registers and should 247 + * not be accessed from here 248 + */ 247 249 }, 248 250 }, 249 251 [AB8500_USB] = { ··· 589 587 .first = 0x40, 590 588 .last = 0x48, 591 589 }, 592 - /* 0x80-0x8B is SIM registers and should 593 - * not be accessed from here */ 590 + /* 591 + * 0x80-0x8B are SIM registers and should 592 + * not be accessed from here 593 + */ 594 594 }, 595 595 }, 596 596 [AB8500_USB] = { ··· 1310 1306 if (s) { 1311 1307 seq_printf(s, " [0x%02X/0x%02X]: 0x%02X\n", 1312 1308 bank, reg, value); 1313 - /* Error is not returned here since 1314 - * the output is wanted in any case */ 1309 + /* 1310 + * Error is not returned here since 1311 + * the output is wanted in any case 1312 + */ 1315 1313 if (seq_has_overflowed(s)) 1316 1314 return 0; 1317 1315 } else { ··· 2746 2740 *cfg = loc; 2747 2741 2748 2742 #ifdef ABB_HWREG_DEBUG 2749 - pr_warn("HWREG request: %s, %s,\n" 2750 - " addr=0x%08X, mask=0x%X, shift=%d" "value=0x%X\n", 2751 - (write) ? "write" : "read", 2752 - REG_FMT_DEC(cfg) ? "decimal" : "hexa", 2743 + pr_warn("HWREG request: %s, %s,\n", (write) ? "write" : "read", 2744 + REG_FMT_DEC(cfg) ? "decimal" : "hexa"); 2745 + pr_warn(" addr=0x%08X, mask=0x%X, shift=%d" "value=0x%X\n", 2753 2746 cfg->addr, cfg->mask, cfg->shift, val); 2754 2747 #endif 2755 2748