Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

phy: qualcomm: phy-qcom-ipq806x-sata: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-15-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Uwe Kleine-König and committed by
Vinod Koul
de6862d1 e5ce6d9d

+2 -4
+2 -4
drivers/phy/qualcomm/phy-qcom-ipq806x-sata.c
··· 170 170 return 0; 171 171 } 172 172 173 - static int qcom_ipq806x_sata_phy_remove(struct platform_device *pdev) 173 + static void qcom_ipq806x_sata_phy_remove(struct platform_device *pdev) 174 174 { 175 175 struct qcom_ipq806x_sata_phy *phy = platform_get_drvdata(pdev); 176 176 177 177 clk_disable_unprepare(phy->cfg_clk); 178 - 179 - return 0; 180 178 } 181 179 182 180 static const struct of_device_id qcom_ipq806x_sata_phy_of_match[] = { ··· 185 187 186 188 static struct platform_driver qcom_ipq806x_sata_phy_driver = { 187 189 .probe = qcom_ipq806x_sata_phy_probe, 188 - .remove = qcom_ipq806x_sata_phy_remove, 190 + .remove_new = qcom_ipq806x_sata_phy_remove, 189 191 .driver = { 190 192 .name = "qcom-ipq806x-sata-phy", 191 193 .of_match_table = qcom_ipq806x_sata_phy_of_match,