Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/mipi-dsi: use correct return type for the DSC functions

The functions mipi_dsi_compression_mode() and
mipi_dsi_picture_parameter_set() return 0-or-error rather than a buffer
size. Follow example of other similar MIPI DSI functions and use int
return type instead of size_t.

Fixes: f4dea1aaa9a1 ("drm/dsi: add helpers for DSI compression mode and PPS packets")
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240408-lg-sw43408-panel-v5-2-4e092da22991@linaro.org

+6 -6
+3 -3
drivers/gpu/drm/drm_mipi_dsi.c
··· 654 654 * 655 655 * Return: 0 on success or a negative error code on failure. 656 656 */ 657 - ssize_t mipi_dsi_compression_mode(struct mipi_dsi_device *dsi, bool enable) 657 + int mipi_dsi_compression_mode(struct mipi_dsi_device *dsi, bool enable) 658 658 { 659 659 /* Note: Needs updating for non-default PPS or algorithm */ 660 660 u8 tx[2] = { enable << 0, 0 }; ··· 679 679 * 680 680 * Return: 0 on success or a negative error code on failure. 681 681 */ 682 - ssize_t mipi_dsi_picture_parameter_set(struct mipi_dsi_device *dsi, 683 - const struct drm_dsc_picture_parameter_set *pps) 682 + int mipi_dsi_picture_parameter_set(struct mipi_dsi_device *dsi, 683 + const struct drm_dsc_picture_parameter_set *pps) 684 684 { 685 685 struct mipi_dsi_msg msg = { 686 686 .channel = dsi->channel,
+3 -3
include/drm/drm_mipi_dsi.h
··· 241 241 int mipi_dsi_turn_on_peripheral(struct mipi_dsi_device *dsi); 242 242 int mipi_dsi_set_maximum_return_packet_size(struct mipi_dsi_device *dsi, 243 243 u16 value); 244 - ssize_t mipi_dsi_compression_mode(struct mipi_dsi_device *dsi, bool enable); 245 - ssize_t mipi_dsi_picture_parameter_set(struct mipi_dsi_device *dsi, 246 - const struct drm_dsc_picture_parameter_set *pps); 244 + int mipi_dsi_compression_mode(struct mipi_dsi_device *dsi, bool enable); 245 + int mipi_dsi_picture_parameter_set(struct mipi_dsi_device *dsi, 246 + const struct drm_dsc_picture_parameter_set *pps); 247 247 248 248 ssize_t mipi_dsi_generic_write(struct mipi_dsi_device *dsi, const void *payload, 249 249 size_t size);