Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()

hd44780_probe() allocates a memory chunk for hd with kzalloc() and
makes "lcd->drvdata->hd44780" point to it. When we call hd44780_remove(),
we should release all relevant memory and resource. But "lcd->drvdata
->hd44780" is not released, which will lead to a memory leak.

We should release the "lcd->drvdata->hd44780" in hd44780_remove() to fix
the memory leak bug.

Fixes: 718e05ed92ec ("auxdisplay: Introduce hd44780_common.[ch]")
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

authored by

Jianglei Nie and committed by
Miguel Ojeda
ddf75a86 830b3c68

+2
+2
drivers/auxdisplay/hd44780.c
··· 322 322 static int hd44780_remove(struct platform_device *pdev) 323 323 { 324 324 struct charlcd *lcd = platform_get_drvdata(pdev); 325 + struct hd44780_common *hdc = lcd->drvdata; 325 326 326 327 charlcd_unregister(lcd); 328 + kfree(hdc->hd44780); 327 329 kfree(lcd->drvdata); 328 330 329 331 kfree(lcd);