Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARM: mm: correct pte_same behaviour for LPAE.

For 3 levels of paging the PTE_EXT_NG bit will be set for user
address ptes that are written to a page table but not for ptes
created with mk_pte.

This can cause some comparison tests made by pte_same to fail
spuriously and lead to other problems.

To correct this behaviour, we mask off PTE_EXT_NG for any pte that
is present before running the comparison.

Signed-off-by: Steve Capper <steve.capper@linaro.org>
Reviewed-by: Will Deacon <will.deacon@arm.com>

+17
+17
arch/arm/include/asm/pgtable-3level.h
··· 166 166 clean_pmd_entry(pmdp); \ 167 167 } while (0) 168 168 169 + /* 170 + * For 3 levels of paging the PTE_EXT_NG bit will be set for user address ptes 171 + * that are written to a page table but not for ptes created with mk_pte. 172 + * 173 + * In hugetlb_no_page, a new huge pte (new_pte) is generated and passed to 174 + * hugetlb_cow, where it is compared with an entry in a page table. 175 + * This comparison test fails erroneously leading ultimately to a memory leak. 176 + * 177 + * To correct this behaviour, we mask off PTE_EXT_NG for any pte that is 178 + * present before running the comparison. 179 + */ 180 + #define __HAVE_ARCH_PTE_SAME 181 + #define pte_same(pte_a,pte_b) ((pte_present(pte_a) ? pte_val(pte_a) & ~PTE_EXT_NG \ 182 + : pte_val(pte_a)) \ 183 + == (pte_present(pte_b) ? pte_val(pte_b) & ~PTE_EXT_NG \ 184 + : pte_val(pte_b))) 185 + 169 186 #define set_pte_ext(ptep,pte,ext) cpu_set_pte_ext(ptep,__pte(pte_val(pte)|(ext))) 170 187 171 188 #endif /* __ASSEMBLY__ */