Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

thermal: int340x: Fix unexpected shutdown at critical temperature

We are seeing thermal shutdown on Intel based mobile workstations, the
shutdown happens during the first trip handle in
thermal_zone_device_register():
kernel: thermal thermal_zone15: critical temperature reached (101 C), shutting down

However, we shouldn't do a thermal shutdown here, since
1) We may want to use a dedicated daemon, Intel's thermald in this case,
to handle thermal shutdown.

2) For ACPI based system, _CRT doesn't mean shutdown unless it's inside
ThermalZone namespace. ACPI Spec, 11.4.4 _CRT (Critical Temperature):
"... If this object it present under a device, the device’s driver
evaluates this object to determine the device’s critical cooling
temperature trip point. This value may then be used by the device’s
driver to program an internal device temperature sensor trip point."

So a "critical trip" here merely means we should take a more aggressive
cooling method.

As int340x device isn't present under ACPI ThermalZone, override the
default .critical callback to prevent surprising thermal shutdown.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20201221172345.36976-1-kai.heng.feng@canonical.com

authored by

Kai-Heng Feng and committed by
Daniel Lezcano
dd47366a d0df264f

+6
+6
drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c
··· 146 146 return 0; 147 147 } 148 148 149 + static void int340x_thermal_critical(struct thermal_zone_device *zone) 150 + { 151 + dev_dbg(&zone->device, "%s: critical temperature reached\n", zone->type); 152 + } 153 + 149 154 static struct thermal_zone_device_ops int340x_thermal_zone_ops = { 150 155 .get_temp = int340x_thermal_get_zone_temp, 151 156 .get_trip_temp = int340x_thermal_get_trip_temp, 152 157 .get_trip_type = int340x_thermal_get_trip_type, 153 158 .set_trip_temp = int340x_thermal_set_trip_temp, 154 159 .get_trip_hyst = int340x_thermal_get_trip_hyst, 160 + .critical = int340x_thermal_critical, 155 161 }; 156 162 157 163 static int int340x_thermal_get_trip_config(acpi_handle handle, char *name,