Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ipvs: fix inability to remove a mixed-family RS

The current code prevents any operation with a mixed-family dest
unless IP_VS_CONN_F_TUNNEL flag is set. The problem is that it's impossible
for the client to follow this rule, because ip_vs_genl_parse_dest does
not even read the destination conn_flags when cmd = IPVS_CMD_DEL_DEST
(need_full_dest = 0).

Also, not every client can pass this flag when removing a dest. ipvsadm,
for example, does not support the "-i" command line option together with
the "-d" option.

This change disables any checks for mixed-family on IPVS_CMD_DEL_DEST command.

Signed-off-by: Alexey Andriyanov <alan@al-an.info>
Fixes: bc18d37f676f ("ipvs: Allow heterogeneous pools now that we support them")
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

authored by

Alexey Andriyanov and committed by
Simon Horman
dd3733b3 42b5212f

+1 -1
+1 -1
net/netfilter/ipvs/ip_vs_ctl.c
··· 3399 3399 if (udest.af == 0) 3400 3400 udest.af = svc->af; 3401 3401 3402 - if (udest.af != svc->af) { 3402 + if (udest.af != svc->af && cmd != IPVS_CMD_DEL_DEST) { 3403 3403 /* The synchronization protocol is incompatible 3404 3404 * with mixed family services 3405 3405 */