Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ACPI / LPSS: Only call pwm_add_table() for the first PWM controller

At least on the UP board SBC both PWMs are enabled leading to us
trying to add the same pwm_lookup twice, which leads to the following:

[ 0.902224] list_add double add: new=ffffffffb8efd400,
prev=ffffffffb8efd400, next=ffffffffb8eeede0.
[ 0.912466] ------------[ cut here ]------------
[ 0.917624] kernel BUG at lib/list_debug.c:31!
[ 0.922588] invalid opcode: 0000 [#1] SMP
...
[ 1.027450] Call Trace:
[ 1.030185] pwm_add_table+0x4c/0x90
[ 1.034181] bsw_pwm_setup+0x1a/0x20
[ 1.038175] acpi_lpss_create_device+0xfe/0x420
...

This commit fixes this by only calling pwm_add_table() for the first
PWM controller (which is the one used for the backlight).

Link: https://bugzilla.redhat.com/show_bug.cgi?id=1458599
Fixes: bf7696a12071 (acpi: lpss: call pwm_add_table() for BSW...)
Fixes: 04434ab5120a (ACPI / LPSS: Call pwm_add_table() for Bay Trail...)
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: 4.11+ <stable@vger.kernel.org> # 4.11+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

authored by

Hans de Goede and committed by
Rafael J. Wysocki
dd242a08 6f7da290

+14
+14
drivers/acpi/acpi_lpss.c
··· 85 85 }; 86 86 87 87 struct lpss_private_data { 88 + struct acpi_device *adev; 88 89 void __iomem *mmio_base; 89 90 resource_size_t mmio_size; 90 91 unsigned int fixed_clk_rate; ··· 156 155 157 156 static void byt_pwm_setup(struct lpss_private_data *pdata) 158 157 { 158 + struct acpi_device *adev = pdata->adev; 159 + 160 + /* Only call pwm_add_table for the first PWM controller */ 161 + if (!adev->pnp.unique_id || strcmp(adev->pnp.unique_id, "1")) 162 + return; 163 + 159 164 if (!acpi_dev_present("INT33FD", NULL, -1)) 160 165 pwm_add_table(byt_pwm_lookup, ARRAY_SIZE(byt_pwm_lookup)); 161 166 } ··· 187 180 188 181 static void bsw_pwm_setup(struct lpss_private_data *pdata) 189 182 { 183 + struct acpi_device *adev = pdata->adev; 184 + 185 + /* Only call pwm_add_table for the first PWM controller */ 186 + if (!adev->pnp.unique_id || strcmp(adev->pnp.unique_id, "1")) 187 + return; 188 + 190 189 pwm_add_table(bsw_pwm_lookup, ARRAY_SIZE(bsw_pwm_lookup)); 191 190 } 192 191 ··· 469 456 goto err_out; 470 457 } 471 458 459 + pdata->adev = adev; 472 460 pdata->dev_desc = dev_desc; 473 461 474 462 if (dev_desc->setup)