Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()

It's legal to have 'offset + len' equal to
sizeof(struct virtio_net_config), since 'ndev->config' is a
'struct virtio_net_config', so we can safely copy its content under
this condition.

Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Cc: stable@vger.kernel.org
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Link: https://lore.kernel.org/r/20210208161741.104939-1-sgarzare@redhat.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Eli Cohen <elic@nvidia.com>

authored by

Stefano Garzarella and committed by
Michael S. Tsirkin
dcfde163 95efabf0

+1 -1
+1 -1
drivers/vdpa/mlx5/net/mlx5_vnet.c
··· 1820 1820 struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev); 1821 1821 struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev); 1822 1822 1823 - if (offset + len < sizeof(struct virtio_net_config)) 1823 + if (offset + len <= sizeof(struct virtio_net_config)) 1824 1824 memcpy(buf, (u8 *)&ndev->config + offset, len); 1825 1825 } 1826 1826