Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: light: fix improper return value

In function cm3232_reg_init(), it returns 0 even if the last call to
i2c_smbus_write_byte_data() returns a negative value (indicates error).
As a result, the return value may be inconsistent with the execution
status, and the caller of cm3232_reg_init() will not be able to detect
the error. This patch fixes the bug.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188641

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

authored by

Pan Bian and committed by
Jonathan Cameron
db4e5376 67351df7

+1 -1
+1 -1
drivers/iio/light/cm3232.c
··· 119 119 if (ret < 0) 120 120 dev_err(&chip->client->dev, "Error writing reg_cmd\n"); 121 121 122 - return 0; 122 + return ret; 123 123 } 124 124 125 125 /**