Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[RTNETLINK] Cleanup rtnetlink_link tables

Converts remaining rtnetlink_link tables to use c99 designated
initializers to make greping a little bit easier.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Thomas Graf and committed by
David S. Miller
db46edc6 f90a0a74

+30 -26
+2
include/linux/rtnetlink.h
··· 93 93 #define RTM_MAX (((__RTM_MAX + 3) & ~3) - 1) 94 94 }; 95 95 96 + #define RTM_NR_MSGTYPES (RTM_MAX + 1 - RTM_BASE) 97 + #define RTM_NR_FAMILIES (RTM_NR_MSGTYPES >> 2) 96 98 #define RTM_FAM(cmd) (((cmd) - RTM_BASE) >> 2) 97 99 98 100 /*
+3 -3
net/core/rtnetlink.c
··· 86 86 87 87 struct rtnetlink_link * rtnetlink_links[NPROTO]; 88 88 89 - static const int rtm_min[(RTM_MAX+1-RTM_BASE)/4] = 89 + static const int rtm_min[RTM_NR_FAMILIES] = 90 90 { 91 91 [RTM_FAM(RTM_NEWLINK)] = NLMSG_LENGTH(sizeof(struct ifinfomsg)), 92 92 [RTM_FAM(RTM_NEWADDR)] = NLMSG_LENGTH(sizeof(struct ifaddrmsg)), ··· 102 102 [RTM_FAM(RTM_GETANYCAST)] = NLMSG_LENGTH(sizeof(struct rtgenmsg)), 103 103 }; 104 104 105 - static const int rta_max[(RTM_MAX+1-RTM_BASE)/4] = 105 + static const int rta_max[RTM_NR_FAMILIES] = 106 106 { 107 107 [RTM_FAM(RTM_NEWLINK)] = IFLA_MAX, 108 108 [RTM_FAM(RTM_NEWADDR)] = IFA_MAX, ··· 641 641 } while (rtnl && rtnl->sk_receive_queue.qlen); 642 642 } 643 643 644 - static struct rtnetlink_link link_rtnetlink_table[RTM_MAX-RTM_BASE+1] = 644 + static struct rtnetlink_link link_rtnetlink_table[RTM_NR_MSGTYPES] = 645 645 { 646 646 [RTM_GETLINK - RTM_BASE] = { .dumpit = rtnetlink_dump_ifinfo }, 647 647 [RTM_SETLINK - RTM_BASE] = { .doit = do_setlink },
+13 -12
net/decnet/dn_dev.c
··· 1411 1411 1412 1412 #endif /* CONFIG_PROC_FS */ 1413 1413 1414 - static struct rtnetlink_link dnet_rtnetlink_table[RTM_MAX-RTM_BASE+1] = 1414 + static struct rtnetlink_link dnet_rtnetlink_table[RTM_NR_MSGTYPES] = 1415 1415 { 1416 - [4] = { .doit = dn_dev_rtm_newaddr, }, 1417 - [5] = { .doit = dn_dev_rtm_deladdr, }, 1418 - [6] = { .dumpit = dn_dev_dump_ifaddr, }, 1419 - 1416 + [RTM_NEWADDR - RTM_BASE] = { .doit = dn_dev_rtm_newaddr, }, 1417 + [RTM_DELADDR - RTM_BASE] = { .doit = dn_dev_rtm_deladdr, }, 1418 + [RTM_GETADDR - RTM_BASE] = { .dumpit = dn_dev_dump_ifaddr, }, 1420 1419 #ifdef CONFIG_DECNET_ROUTER 1421 - [8] = { .doit = dn_fib_rtm_newroute, }, 1422 - [9] = { .doit = dn_fib_rtm_delroute, }, 1423 - [10] = { .doit = dn_cache_getroute, .dumpit = dn_fib_dump, }, 1424 - [16] = { .doit = dn_fib_rtm_newrule, }, 1425 - [17] = { .doit = dn_fib_rtm_delrule, }, 1426 - [18] = { .dumpit = dn_fib_dump_rules, }, 1420 + [RTM_NEWROUTE - RTM_BASE] = { .doit = dn_fib_rtm_newroute, }, 1421 + [RTM_DELROUTE - RTM_BASE] = { .doit = dn_fib_rtm_delroute, }, 1422 + [RTM_GETROUTE - RTM_BASE] = { .doit = dn_cache_getroute, 1423 + .dumpit = dn_fib_dump, }, 1424 + [RTM_NEWRULE - RTM_BASE] = { .doit = dn_fib_rtm_newrule, }, 1425 + [RTM_DELRULE - RTM_BASE] = { .doit = dn_fib_rtm_delrule, }, 1426 + [RTM_GETRULE - RTM_BASE] = { .dumpit = dn_fib_dump_rules, }, 1427 1427 #else 1428 - [10] = { .doit = dn_cache_getroute, .dumpit = dn_cache_dump, }, 1428 + [RTM_GETROUTE - RTM_BASE] = { .doit = dn_cache_getroute, 1429 + .dumpit = dn_cache_dump, 1429 1430 #endif 1430 1431 1431 1432 };
+11 -10
net/ipv4/devinet.c
··· 1107 1107 } 1108 1108 } 1109 1109 1110 - static struct rtnetlink_link inet_rtnetlink_table[RTM_MAX - RTM_BASE + 1] = { 1111 - [4] = { .doit = inet_rtm_newaddr, }, 1112 - [5] = { .doit = inet_rtm_deladdr, }, 1113 - [6] = { .dumpit = inet_dump_ifaddr, }, 1114 - [8] = { .doit = inet_rtm_newroute, }, 1115 - [9] = { .doit = inet_rtm_delroute, }, 1116 - [10] = { .doit = inet_rtm_getroute, .dumpit = inet_dump_fib, }, 1110 + static struct rtnetlink_link inet_rtnetlink_table[RTM_NR_MSGTYPES] = { 1111 + [RTM_NEWADDR - RTM_BASE] = { .doit = inet_rtm_newaddr, }, 1112 + [RTM_DELADDR - RTM_BASE] = { .doit = inet_rtm_deladdr, }, 1113 + [RTM_GETADDR - RTM_BASE] = { .dumpit = inet_dump_ifaddr, }, 1114 + [RTM_NEWROUTE - RTM_BASE] = { .doit = inet_rtm_newroute, }, 1115 + [RTM_DELROUTE - RTM_BASE] = { .doit = inet_rtm_delroute, }, 1116 + [RTM_GETROUTE - RTM_BASE] = { .doit = inet_rtm_getroute, 1117 + .dumpit = inet_dump_fib, }, 1117 1118 #ifdef CONFIG_IP_MULTIPLE_TABLES 1118 - [16] = { .doit = inet_rtm_newrule, }, 1119 - [17] = { .doit = inet_rtm_delrule, }, 1120 - [18] = { .dumpit = inet_dump_rules, }, 1119 + [RTM_NEWRULE - RTM_BASE] = { .doit = inet_rtm_newrule, }, 1120 + [RTM_DELRULE - RTM_BASE] = { .doit = inet_rtm_delrule, }, 1121 + [RTM_GETRULE - RTM_BASE] = { .dumpit = inet_dump_rules, }, 1121 1122 #endif 1122 1123 }; 1123 1124
+1 -1
net/ipv6/addrconf.c
··· 3076 3076 netlink_broadcast(rtnl, skb, 0, RTMGRP_IPV6_PREFIX, GFP_ATOMIC); 3077 3077 } 3078 3078 3079 - static struct rtnetlink_link inet6_rtnetlink_table[RTM_MAX - RTM_BASE + 1] = { 3079 + static struct rtnetlink_link inet6_rtnetlink_table[RTM_NR_MSGTYPES] = { 3080 3080 [RTM_GETLINK - RTM_BASE] = { .dumpit = inet6_dump_ifinfo, }, 3081 3081 [RTM_NEWADDR - RTM_BASE] = { .doit = inet6_rtm_newaddr, }, 3082 3082 [RTM_DELADDR - RTM_BASE] = { .doit = inet6_rtm_deladdr, },