Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mfd: intel_soc_pmic_core: Fix unchecked return value

unction devm_regmap_init_i2c() returns an ERR_PTR on errors, and its
return value should be checked before it is dereferenced. However, in
function intel_soc_pmic_i2c_probe(), the return value of function
devm_regmap_init_i2c() is used without validation. This patch fixes it.

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

authored by

Pan Bian and committed by
Lee Jones
db43b8d0 d1f4f01a

+3
+3
drivers/mfd/intel_soc_pmic_core.c
··· 66 66 dev_set_drvdata(dev, pmic); 67 67 68 68 pmic->regmap = devm_regmap_init_i2c(i2c, config->regmap_config); 69 + if (IS_ERR(pmic->regmap)) 70 + return PTR_ERR(pmic->regmap); 71 + 69 72 pmic->irq = i2c->irq; 70 73 71 74 ret = regmap_add_irq_chip(pmic->regmap, pmic->irq,