Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/imx/lcdc: fix a NULL vs IS_ERR() bug in probe

The devm_drm_dev_alloc() function returns error pointers. It never
returns NULL. Fix the check.

Fixes: c87e859cdeb5 ("drm/imx/lcdc: Implement DRM driver for imx25")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/d0a1fc55-3ef6-444e-b3ef-fdc937d8d57a@kili.mountain

authored by

Dan Carpenter and committed by
Javier Martinez Canillas
dae2f7b8 ebb7619d

+2 -2
+2 -2
drivers/gpu/drm/imx/lcdc/imx-lcdc.c
··· 400 400 401 401 lcdc = devm_drm_dev_alloc(dev, &imx_lcdc_drm_driver, 402 402 struct imx_lcdc, drm); 403 - if (!lcdc) 404 - return -ENOMEM; 403 + if (IS_ERR(lcdc)) 404 + return PTR_ERR(lcdc); 405 405 406 406 drm = &lcdc->drm; 407 407