Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fs/mnt_idmapping.c: Return -EINVAL when no map is written

Currently, it is possible to create an idmapped mount using a user
namespace without any mappings. However, this yields an idmapped
mount that doesn't actually map the ids. With the following change,
it will no longer be possible to create an idmapped mount when using
a user namespace with no mappings, and will instead return EINVAL,
an “invalid argument” error code.

Reviewed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Taylor Jackson <taylor.a.jackson@me.com>
Link: https://lore.kernel.org/r/20240208-mnt-idmap-inval-v2-1-58ef26d194e0@me.com
Signed-off-by: Christian Brauner <brauner@kernel.org>

authored by

Taylor Jackson and committed by
Christian Brauner
dacfd001 d31563b5

+1 -1
+1 -1
fs/mnt_idmapping.c
··· 214 214 * anything at all. 215 215 */ 216 216 if (nr_extents == 0) 217 - return 0; 217 + return -EINVAL; 218 218 219 219 /* 220 220 * Here we know that nr_extents is greater than zero which means