tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/amd/display: replace FIXME with TODO
Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
Reviewed-by: Charlene Liu <Charlene.Liu@amd.com>
Acked-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
authored by
Qingqing Zhuo
and committed by
Alex Deucher
dabeea64
b1319322
+13
-13
+4
-4
drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c
+4
-4
drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c
···
207
207
rq_regs->rq_regs_l.swath_height = dml_log2(rq_param.dlg.rq_l.swath_height);
208
208
rq_regs->rq_regs_c.swath_height = dml_log2(rq_param.dlg.rq_c.swath_height);
209
209
210
-
// FIXME: take the max between luma, chroma chunk size?
210
+
// TODO: take the max between luma, chroma chunk size?
211
211
// okay for now, as we are setting chunk_bytes to 8kb anyways
212
212
if (rq_param.sizing.rq_l.chunk_bytes >= 32 * 1024) { //32kb
213
213
rq_regs->drq_expansion_mode = 0;
···
677
677
unsigned int meta_pitch = 0;
678
678
unsigned int ppe = mode_422 ? 2 : 1;
679
679
680
-
// FIXME check if ppe apply for both luma and chroma in 422 case
680
+
// TODO check if ppe apply for both luma and chroma in 422 case
681
681
if (is_chroma) {
682
682
vp_width = pipe_src_param.viewport_width_c / ppe;
683
683
vp_height = pipe_src_param.viewport_height_c;
···
959
959
// Source
960
960
// dcc_en = src.dcc;
961
961
dual_plane = is_dual_plane((enum source_format_class)(src->source_format));
962
-
mode_422 = 0; // FIXME
962
+
mode_422 = 0; // TODO
963
963
access_dir = (src->source_scan == dm_vert); // vp access direction: horizontal or vertical accessed
964
964
// bytes_per_element_l = get_bytes_per_element(source_format_class(src.source_format), 0);
965
965
// bytes_per_element_c = get_bytes_per_element(source_format_class(src.source_format), 1);
···
1655
1655
cur_width_ub = dml_ceil((double) cur_src_width / (double) cur_req_width, 1)
1656
1656
* (double) cur_req_width;
1657
1657
cur_req_per_width = cur_width_ub / (double) cur_req_width;
1658
-
hactive_cur = (double) cur_src_width / hscl_ratio; // FIXME: oswin to think about what to do for cursor
1658
+
hactive_cur = (double) cur_src_width / hscl_ratio; // TODO: oswin to think about what to do for cursor
1659
1659
1660
1660
if (vratio_pre_l <= 1.0) {
1661
1661
*refcyc_per_req_delivery_pre_cur = hactive_cur * ref_freq_to_pix_freq
+4
-4
drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c
+4
-4
drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c
···
207
207
rq_regs->rq_regs_l.swath_height = dml_log2(rq_param.dlg.rq_l.swath_height);
208
208
rq_regs->rq_regs_c.swath_height = dml_log2(rq_param.dlg.rq_c.swath_height);
209
209
210
-
// FIXME: take the max between luma, chroma chunk size?
210
+
// TODO: take the max between luma, chroma chunk size?
211
211
// okay for now, as we are setting chunk_bytes to 8kb anyways
212
212
if (rq_param.sizing.rq_l.chunk_bytes >= 32 * 1024) { //32kb
213
213
rq_regs->drq_expansion_mode = 0;
···
677
677
unsigned int meta_pitch = 0;
678
678
unsigned int ppe = mode_422 ? 2 : 1;
679
679
680
-
// FIXME check if ppe apply for both luma and chroma in 422 case
680
+
// TODO check if ppe apply for both luma and chroma in 422 case
681
681
if (is_chroma) {
682
682
vp_width = pipe_src_param.viewport_width_c / ppe;
683
683
vp_height = pipe_src_param.viewport_height_c;
···
959
959
// Source
960
960
// dcc_en = src.dcc;
961
961
dual_plane = is_dual_plane((enum source_format_class)(src->source_format));
962
-
mode_422 = 0; // FIXME
962
+
mode_422 = 0; // TODO
963
963
access_dir = (src->source_scan == dm_vert); // vp access direction: horizontal or vertical accessed
964
964
// bytes_per_element_l = get_bytes_per_element(source_format_class(src.source_format), 0);
965
965
// bytes_per_element_c = get_bytes_per_element(source_format_class(src.source_format), 1);
···
1655
1655
cur_width_ub = dml_ceil((double) cur_src_width / (double) cur_req_width, 1)
1656
1656
* (double) cur_req_width;
1657
1657
cur_req_per_width = cur_width_ub / (double) cur_req_width;
1658
-
hactive_cur = (double) cur_src_width / hscl_ratio; // FIXME: oswin to think about what to do for cursor
1658
+
hactive_cur = (double) cur_src_width / hscl_ratio; // TODO: oswin to think about what to do for cursor
1659
1659
1660
1660
if (vratio_pre_l <= 1.0) {
1661
1661
*refcyc_per_req_delivery_pre_cur = hactive_cur * ref_freq_to_pix_freq
+5
-5
drivers/gpu/drm/amd/display/dc/dml/dml1_display_rq_dlg_calc.c
+5
-5
drivers/gpu/drm/amd/display/dc/dml/dml1_display_rq_dlg_calc.c
···
243
243
rq_regs->rq_regs_l.swath_height = dml_log2(rq_param.dlg.rq_l.swath_height);
244
244
rq_regs->rq_regs_c.swath_height = dml_log2(rq_param.dlg.rq_c.swath_height);
245
245
246
-
/* FIXME: take the max between luma, chroma chunk size?
246
+
/* TODO: take the max between luma, chroma chunk size?
247
247
* okay for now, as we are setting chunk_bytes to 8kb anyways
248
248
*/
249
249
if (rq_param.sizing.rq_l.chunk_bytes >= 32 * 1024) { /*32kb */
···
602
602
unsigned int log2_dpte_group_length;
603
603
unsigned int func_meta_row_height, func_dpte_row_height;
604
604
605
-
/* FIXME check if ppe apply for both luma and chroma in 422 case */
605
+
/* TODO check if ppe apply for both luma and chroma in 422 case */
606
606
if (is_chroma) {
607
607
vp_width = pipe_src_param.viewport_width_c / ppe;
608
608
vp_height = pipe_src_param.viewport_height_c;
···
1141
1141
ASSERT(disp_dlg_regs->refcyc_h_blank_end < (unsigned int) dml_pow(2, 13));
1142
1142
disp_dlg_regs->dlg_vblank_end = interlaced ? (vblank_end / 2) : vblank_end; /* 15 bits */
1143
1143
1144
-
prefetch_xy_calc_in_dcfclk = 24.0; /* FIXME: ip_param */
1144
+
prefetch_xy_calc_in_dcfclk = 24.0; /* TODO: ip_param */
1145
1145
min_dcfclk_mhz = dlg_sys_param.deepsleep_dcfclk_mhz;
1146
1146
t_calc_us = prefetch_xy_calc_in_dcfclk / min_dcfclk_mhz;
1147
1147
min_ttu_vblank = dlg_sys_param.t_urg_wm_us;
···
1182
1182
dcc_en = e2e_pipe_param.pipe.src.dcc;
1183
1183
dual_plane = is_dual_plane(
1184
1184
(enum source_format_class) e2e_pipe_param.pipe.src.source_format);
1185
-
mode_422 = 0; /* FIXME */
1185
+
mode_422 = 0; /* TODO */
1186
1186
access_dir = (e2e_pipe_param.pipe.src.source_scan == dm_vert); /* vp access direction: horizontal or vertical accessed */
1187
1187
bytes_per_element_l = get_bytes_per_element(
1188
1188
(enum source_format_class) e2e_pipe_param.pipe.src.source_format,
···
1837
1837
cur0_width_ub = dml_ceil((double) cur0_src_width / (double) cur0_req_width, 1)
1838
1838
* (double) cur0_req_width;
1839
1839
cur0_req_per_width = cur0_width_ub / (double) cur0_req_width;
1840
-
hactive_cur0 = (double) cur0_src_width / hratios_cur0; /* FIXME: oswin to think about what to do for cursor */
1840
+
hactive_cur0 = (double) cur0_src_width / hratios_cur0; /* TODO: oswin to think about what to do for cursor */
1841
1841
1842
1842
if (vratio_pre_l <= 1.0) {
1843
1843
refcyc_per_req_delivery_pre_cur0 = hactive_cur0 * ref_freq_to_pix_freq