(I'm so sorry!) Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

net: emac: mal: replace devm_request_irq with request_irq to fix probe error race

devm_request_irq() is a managed resource: the IRQ is not freed until devres_release_all() runs after the probe function returns. In the probe error path, free_netdev(mal->dummy_dev) and dcr_unmap() execute while the IRQ is still live. If the shared IRQ fires during cleanup, the handler accesses unmapped DCR registers (crash) or the already- freed dummy_dev (use-after-free). Switch to plain request_irq() with per-IRQ error labels that tear down only the IRQs that were successfully registered, and add the matching free_irq() calls in mal_remove(). Cc: stable+noautosel@kernel.org # LLM report + LLM fix, untested Fixes: 14f59154ff0b ("net: ibm: emac: mal: use devm for request_irq") Signed-off-by: Rosen Penev <rosenp@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://patch.msgid.link/20261007183821.928263-1-rosenp@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>


Author Rosen Penev Committer Jakub Kicinski Date Commit Parent 207d1c23
+29 -14
1 changed file
+29 -14
1 changed file