Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: versatile: Add of_node_put() before return statement

Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.

Fix a potential memory leak in clk-impd1.c by inserting
of_node_put() before a return statement.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Link: https://lore.kernel.org/r/20200829175704.GA10998@Kaladin
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

authored by

Sumera Priyadarsini and committed by
Stephen Boyd
da9c43dc 73a203b0

+3 -1
+3 -1
drivers/clk/versatile/clk-impd1.c
··· 109 109 110 110 for_each_available_child_of_node(np, child) { 111 111 ret = integrator_impd1_clk_spawn(dev, np, child); 112 - if (ret) 112 + if (ret) { 113 + of_node_put(child); 113 114 break; 115 + } 114 116 } 115 117 116 118 return ret;