Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: vt6655: remove duplicate MACvSetPacketFilter

Packet filtering is already done in vnt_configure.

A call to MACvSetPacketFilter is not necessary in MACvInitialize as
this will be done by vnt_configure when interface is up.

Also remove macros associated with this function.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Malcolm Priestley and committed by
Greg Kroah-Hartman
da4f18ed 6d8b588c

-79
-66
drivers/staging/vt6655/mac.c
··· 33 33 * MACvGetShortRetryLimit - Get 802.11 Short Retry limit 34 34 * MACvSetLongRetryLimit - Set 802.11 Long Retry limit 35 35 * MACvSetLoopbackMode - Set MAC Loopback Mode 36 - * MACvSetPacketFilter - Set MAC Address Filter 37 36 * MACvSaveContext - Save Context of MAC Registers 38 37 * MACvRestoreContext - Restore Context of MAC Registers 39 38 * MACbSoftwareReset - Software Reset MAC ··· 210 211 byOrgValue = byOrgValue & 0x3F; 211 212 byOrgValue = byOrgValue | byLoopbackMode; 212 213 VNSvOutPortB(dwIoBase + MAC_REG_TEST, byOrgValue); 213 - } 214 - 215 - /* 216 - * Description: 217 - * Set MAC Address filter 218 - * 219 - * Parameters: 220 - * In: 221 - * dwIoBase - Base Address for MAC 222 - * wFilterType - Filter Type 223 - * Out: 224 - * none 225 - * 226 - * Return Value: none 227 - * 228 - */ 229 - void MACvSetPacketFilter(void __iomem *dwIoBase, unsigned short wFilterType) 230 - { 231 - unsigned char byOldRCR; 232 - unsigned char byNewRCR = 0; 233 - 234 - // if only in DIRECTED mode, multicast-address will set to zero, 235 - // but if other mode exist (e.g. PROMISCUOUS), multicast-address 236 - // will be open 237 - if (wFilterType & PKT_TYPE_DIRECTED) { 238 - // set multicast address to accept none 239 - MACvSelectPage1(dwIoBase); 240 - VNSvOutPortD(dwIoBase + MAC_REG_MAR0, 0L); 241 - VNSvOutPortD(dwIoBase + MAC_REG_MAR0 + sizeof(unsigned long), 0L); 242 - MACvSelectPage0(dwIoBase); 243 - } 244 - 245 - if (wFilterType & (PKT_TYPE_PROMISCUOUS | PKT_TYPE_ALL_MULTICAST)) { 246 - // set multicast address to accept all 247 - MACvSelectPage1(dwIoBase); 248 - VNSvOutPortD(dwIoBase + MAC_REG_MAR0, 0xFFFFFFFFL); 249 - VNSvOutPortD(dwIoBase + MAC_REG_MAR0 + sizeof(unsigned long), 0xFFFFFFFFL); 250 - MACvSelectPage0(dwIoBase); 251 - } 252 - 253 - if (wFilterType & PKT_TYPE_PROMISCUOUS) { 254 - byNewRCR |= (RCR_RXALLTYPE | RCR_UNICAST | RCR_MULTICAST | RCR_BROADCAST); 255 - 256 - byNewRCR &= ~RCR_BSSID; 257 - } 258 - 259 - if (wFilterType & (PKT_TYPE_ALL_MULTICAST | PKT_TYPE_MULTICAST)) 260 - byNewRCR |= RCR_MULTICAST; 261 - 262 - if (wFilterType & PKT_TYPE_BROADCAST) 263 - byNewRCR |= RCR_BROADCAST; 264 - 265 - if (wFilterType & PKT_TYPE_ERROR_CRC) 266 - byNewRCR |= RCR_ERRCRC; 267 - 268 - VNSvInPortB(dwIoBase + MAC_REG_RCR, &byOldRCR); 269 - if (byNewRCR != byOldRCR) { 270 - // Modify the Receive Command Register 271 - VNSvOutPortB(dwIoBase + MAC_REG_RCR, byNewRCR); 272 - } 273 214 } 274 215 275 216 /* ··· 568 629 VNSvOutPortB(dwIoBase + MAC_REG_TFTCTL, TFTCTL_TSFCNTRST); 569 630 // enable TSF counter 570 631 VNSvOutPortB(dwIoBase + MAC_REG_TFTCTL, TFTCTL_TSFCNTREN); 571 - 572 - // set packet filter 573 - // receive directed and broadcast address 574 - 575 - MACvSetPacketFilter(dwIoBase, PKT_TYPE_DIRECTED | PKT_TYPE_BROADCAST); 576 632 } 577 633 578 634 /*
-13
drivers/staging/vt6655/mac.h
··· 574 574 #define MAC_LB_INTERNAL 0x01 // 575 575 #define MAC_LB_NONE 0x00 // 576 576 577 - // Ethernet address filter type 578 - #define PKT_TYPE_NONE 0x00 // turn off receiver 579 - #define PKT_TYPE_ALL_MULTICAST 0x80 580 - #define PKT_TYPE_PROMISCUOUS 0x40 581 - #define PKT_TYPE_DIRECTED 0x20 // obsolete, directed address is always accepted 582 - #define PKT_TYPE_BROADCAST 0x10 583 - #define PKT_TYPE_MULTICAST 0x08 584 - #define PKT_TYPE_ERROR_WPA 0x04 585 - #define PKT_TYPE_ERROR_CRC 0x02 586 - #define PKT_TYPE_BSSID 0x01 587 - 588 577 #define Default_BI 0x200 589 578 590 579 // MiscFIFO Offset ··· 964 975 void MACvGetLongRetryLimit(void __iomem *dwIoBase, unsigned char *pbyRetryLimit); 965 976 966 977 void MACvSetLoopbackMode(void __iomem *dwIoBase, unsigned char byLoopbackMode); 967 - 968 - void MACvSetPacketFilter(void __iomem *dwIoBase, unsigned short wFilterType); 969 978 970 979 void MACvSaveContext(void __iomem *dwIoBase, unsigned char *pbyCxtBuf); 971 980 void MACvRestoreContext(void __iomem *dwIoBase, unsigned char *pbyCxtBuf);