Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ACPI: SPCR: Prefix error messages with FW_BUG

The table values that are not defined in the specification are
considered non-fatal errors in the code.

However, they are firmware bugs, so point this out in the messages by
prefixing them with FW_BUG.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

authored by

Andy Shevchenko and committed by
Rafael J. Wysocki
da30a34a 91d7b60a

+2 -2
+2 -2
drivers/acpi/spcr.c
··· 110 110 u32 bit_width = table->serial_port.access_width; 111 111 112 112 if (bit_width > ACPI_ACCESS_BIT_MAX) { 113 - pr_err("Unacceptable wide SPCR Access Width. Defaulting to byte size\n"); 113 + pr_err(FW_BUG "Unacceptable wide SPCR Access Width. Defaulting to byte size\n"); 114 114 bit_width = ACPI_ACCESS_BIT_DEFAULT; 115 115 } 116 116 switch (ACPI_ACCESS_BIT_WIDTH((bit_width))) { 117 117 default: 118 - pr_err("Unexpected SPCR Access Width. Defaulting to byte size\n"); 118 + pr_err(FW_BUG "Unexpected SPCR Access Width. Defaulting to byte size\n"); 119 119 fallthrough; 120 120 case 8: 121 121 iotype = "mmio";