Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: use pr_fmt and pr_<level>

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

authored by

Joe Perches and committed by
Dmitry Torokhov
da0c4901 4eb3c30b

+72 -68
+6 -8
drivers/input/apm-power.c
··· 9 9 * 10 10 */ 11 11 12 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 13 + 12 14 #include <linux/module.h> 13 15 #include <linux/input.h> 14 16 #include <linux/slab.h> ··· 25 23 switch (keycode) { 26 24 case KEY_SUSPEND: 27 25 apm_queue_event(APM_USER_SUSPEND); 28 - 29 - printk(KERN_INFO "apm-power: Requesting system suspend...\n"); 26 + pr_info("Requesting system suspend...\n"); 30 27 break; 31 28 default: 32 29 break; ··· 66 65 67 66 error = input_register_handle(handle); 68 67 if (error) { 69 - printk(KERN_ERR 70 - "apm-power: Failed to register input power handler, " 71 - "error %d\n", error); 68 + pr_err("Failed to register input power handler, error %d\n", 69 + error); 72 70 kfree(handle); 73 71 return error; 74 72 } 75 73 76 74 error = input_open_device(handle); 77 75 if (error) { 78 - printk(KERN_ERR 79 - "apm-power: Failed to open input power device, " 80 - "error %d\n", error); 76 + pr_err("Failed to open input power device, error %d\n", error); 81 77 input_unregister_handle(handle); 82 78 kfree(handle); 83 79 return error;
+10 -8
drivers/input/evbug.c
··· 26 26 * Vojtech Pavlik, Simunkova 1594, Prague 8, 182 00 Czech Republic 27 27 */ 28 28 29 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 30 + 29 31 #include <linux/slab.h> 30 32 #include <linux/module.h> 31 33 #include <linux/input.h> ··· 40 38 41 39 static void evbug_event(struct input_handle *handle, unsigned int type, unsigned int code, int value) 42 40 { 43 - printk(KERN_DEBUG "evbug.c: Event. Dev: %s, Type: %d, Code: %d, Value: %d\n", 44 - dev_name(&handle->dev->dev), type, code, value); 41 + printk(KERN_DEBUG pr_fmt("Event. Dev: %s, Type: %d, Code: %d, Value: %d\n"), 42 + dev_name(&handle->dev->dev), type, code, value); 45 43 } 46 44 47 45 static int evbug_connect(struct input_handler *handler, struct input_dev *dev, ··· 66 64 if (error) 67 65 goto err_unregister_handle; 68 66 69 - printk(KERN_DEBUG "evbug.c: Connected device: %s (%s at %s)\n", 70 - dev_name(&dev->dev), 71 - dev->name ?: "unknown", 72 - dev->phys ?: "unknown"); 67 + printk(KERN_DEBUG pr_fmt("Connected device: %s (%s at %s)\n"), 68 + dev_name(&dev->dev), 69 + dev->name ?: "unknown", 70 + dev->phys ?: "unknown"); 73 71 74 72 return 0; 75 73 ··· 82 80 83 81 static void evbug_disconnect(struct input_handle *handle) 84 82 { 85 - printk(KERN_DEBUG "evbug.c: Disconnected device: %s\n", 86 - dev_name(&handle->dev->dev)); 83 + printk(KERN_DEBUG pr_fmt("Disconnected device: %s\n"), 84 + dev_name(&handle->dev->dev)); 87 85 88 86 input_close_device(handle); 89 87 input_unregister_handle(handle);
+8 -7
drivers/input/evdev.c
··· 8 8 * the Free Software Foundation. 9 9 */ 10 10 11 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 12 + 11 13 #define EVDEV_MINOR_BASE 64 12 14 #define EVDEV_MINORS 32 13 15 #define EVDEV_MIN_BUFFER_SIZE 64U ··· 524 522 if (type == EV_KEY && size == OLD_KEY_MAX) { 525 523 len = OLD_KEY_MAX; 526 524 if (printk_timed_ratelimit(&keymax_warn_time, 10 * 1000)) 527 - printk(KERN_WARNING 528 - "evdev.c(EVIOCGBIT): Suspicious buffer size %u, " 529 - "limiting output to %zu bytes. See " 530 - "http://userweb.kernel.org/~dtor/eviocgbit-bug.html\n", 531 - OLD_KEY_MAX, 532 - BITS_TO_LONGS(OLD_KEY_MAX) * sizeof(long)); 525 + pr_warning("(EVIOCGBIT): Suspicious buffer size %u, " 526 + "limiting output to %zu bytes. See " 527 + "http://userweb.kernel.org/~dtor/eviocgbit-bug.html\n", 528 + OLD_KEY_MAX, 529 + BITS_TO_LONGS(OLD_KEY_MAX) * sizeof(long)); 533 530 } 534 531 535 532 return bits_to_user(bits, len, size, p, compat_mode); ··· 895 894 break; 896 895 897 896 if (minor == EVDEV_MINORS) { 898 - printk(KERN_ERR "evdev: no more free evdev devices\n"); 897 + pr_err("no more free evdev devices\n"); 899 898 return -ENFILE; 900 899 } 901 900
+5 -6
drivers/input/ff-core.c
··· 23 23 24 24 /* #define DEBUG */ 25 25 26 - #define debug(format, arg...) pr_debug("ff-core: " format "\n", ## arg) 26 + #define pr_fmt(fmt) KBUILD_BASENAME ": " fmt 27 27 28 28 #include <linux/input.h> 29 29 #include <linux/module.h> ··· 116 116 117 117 if (effect->type < FF_EFFECT_MIN || effect->type > FF_EFFECT_MAX || 118 118 !test_bit(effect->type, dev->ffbit)) { 119 - debug("invalid or not supported effect type in upload"); 119 + pr_debug("invalid or not supported effect type in upload\n"); 120 120 return -EINVAL; 121 121 } 122 122 ··· 124 124 (effect->u.periodic.waveform < FF_WAVEFORM_MIN || 125 125 effect->u.periodic.waveform > FF_WAVEFORM_MAX || 126 126 !test_bit(effect->u.periodic.waveform, dev->ffbit))) { 127 - debug("invalid or not supported wave form in upload"); 127 + pr_debug("invalid or not supported wave form in upload\n"); 128 128 return -EINVAL; 129 129 } 130 130 ··· 246 246 struct ff_device *ff = dev->ff; 247 247 int i; 248 248 249 - debug("flushing now"); 249 + pr_debug("flushing now\n"); 250 250 251 251 mutex_lock(&ff->mutex); 252 252 ··· 315 315 int i; 316 316 317 317 if (!max_effects) { 318 - printk(KERN_ERR 319 - "ff-core: cannot allocate device without any effects\n"); 318 + pr_err("cannot allocate device without any effects\n"); 320 319 return -EINVAL; 321 320 } 322 321
+15 -16
drivers/input/ff-memless.c
··· 23 23 24 24 /* #define DEBUG */ 25 25 26 - #define debug(format, arg...) pr_debug("ff-memless: " format "\n", ## arg) 26 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 27 27 28 28 #include <linux/slab.h> 29 29 #include <linux/input.h> ··· 129 129 int events = 0; 130 130 int i; 131 131 132 - debug("calculating next timer"); 132 + pr_debug("calculating next timer\n"); 133 133 134 134 for (i = 0; i < FF_MEMLESS_EFFECTS; i++) { 135 135 ··· 149 149 } 150 150 151 151 if (!events) { 152 - debug("no actions"); 152 + pr_debug("no actions\n"); 153 153 del_timer(&ml->timer); 154 154 } else { 155 - debug("timer set"); 155 + pr_debug("timer set\n"); 156 156 mod_timer(&ml->timer, earliest); 157 157 } 158 158 } ··· 173 173 if (envelope->attack_length && 174 174 time_before(now, 175 175 state->play_at + msecs_to_jiffies(envelope->attack_length))) { 176 - debug("value = 0x%x, attack_level = 0x%x", value, 177 - envelope->attack_level); 176 + pr_debug("value = 0x%x, attack_level = 0x%x\n", 177 + value, envelope->attack_level); 178 178 time_from_level = jiffies_to_msecs(now - state->play_at); 179 179 time_of_envelope = envelope->attack_length; 180 180 envelope_level = min_t(__s16, envelope->attack_level, 0x7fff); ··· 191 191 192 192 difference = abs(value) - envelope_level; 193 193 194 - debug("difference = %d", difference); 195 - debug("time_from_level = 0x%x", time_from_level); 196 - debug("time_of_envelope = 0x%x", time_of_envelope); 194 + pr_debug("difference = %d\n", difference); 195 + pr_debug("time_from_level = 0x%x\n", time_from_level); 196 + pr_debug("time_of_envelope = 0x%x\n", time_of_envelope); 197 197 198 198 difference = difference * time_from_level / time_of_envelope; 199 199 200 - debug("difference = %d", difference); 200 + pr_debug("difference = %d\n", difference); 201 201 202 202 return value < 0 ? 203 203 -(difference + envelope_level) : (difference + envelope_level); ··· 215 215 if (effect_type == FF_PERIODIC && test_bit(FF_RUMBLE, ff->ffbit)) 216 216 return FF_RUMBLE; 217 217 218 - printk(KERN_ERR 219 - "ff-memless: invalid type in get_compatible_type()\n"); 218 + pr_err("invalid type in get_compatible_type()\n"); 220 219 221 220 return 0; 222 221 } ··· 311 312 break; 312 313 313 314 default: 314 - printk(KERN_ERR "ff-memless: invalid type in ml_combine_effects()\n"); 315 + pr_err("invalid type in ml_combine_effects()\n"); 315 316 break; 316 317 } 317 318 ··· 405 406 struct ml_device *ml = dev->ff->private; 406 407 unsigned long flags; 407 408 408 - debug("timer: updating effects"); 409 + pr_debug("timer: updating effects\n"); 409 410 410 411 spin_lock_irqsave(&dev->event_lock, flags); 411 412 ml_play_effects(ml); ··· 437 438 struct ml_effect_state *state = &ml->states[effect_id]; 438 439 439 440 if (value > 0) { 440 - debug("initiated play"); 441 + pr_debug("initiated play\n"); 441 442 442 443 __set_bit(FF_EFFECT_STARTED, &state->flags); 443 444 state->count = value; ··· 448 449 state->adj_at = state->play_at; 449 450 450 451 } else { 451 - debug("initiated stop"); 452 + pr_debug("initiated stop\n"); 452 453 453 454 if (test_bit(FF_EFFECT_PLAYING, &state->flags)) 454 455 __set_bit(FF_EFFECT_ABORTING, &state->flags);
+3 -2
drivers/input/input-polldev.c
··· 8 8 * the Free Software Foundation. 9 9 */ 10 10 11 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 12 + 11 13 #include <linux/jiffies.h> 12 14 #include <linux/slab.h> 13 15 #include <linux/mutex.h> ··· 35 33 if (!polldev_users) { 36 34 polldev_wq = create_singlethread_workqueue("ipolldevd"); 37 35 if (!polldev_wq) { 38 - printk(KERN_ERR "input-polldev: failed to create " 39 - "ipolldevd workqueue\n"); 36 + pr_err("failed to create ipolldevd workqueue\n"); 40 37 retval = -ENOMEM; 41 38 goto out; 42 39 }
+11 -11
drivers/input/input.c
··· 10 10 * the Free Software Foundation. 11 11 */ 12 12 13 + #define pr_fmt(fmt) KBUILD_BASENAME ": " fmt 14 + 13 15 #include <linux/init.h> 14 16 #include <linux/types.h> 15 17 #include <linux/input.h> ··· 961 959 962 960 error = handler->connect(handler, dev, id); 963 961 if (error && error != -ENODEV) 964 - printk(KERN_ERR 965 - "input: failed to attach handler %s to device %s, " 966 - "error: %d\n", 967 - handler->name, kobject_name(&dev->dev.kobj), error); 962 + pr_err("failed to attach handler %s to device %s, error: %d\n", 963 + handler->name, kobject_name(&dev->dev.kobj), error); 968 964 969 965 return error; 970 966 } ··· 1820 1820 break; 1821 1821 1822 1822 default: 1823 - printk(KERN_ERR 1824 - "input_set_capability: unknown type %u (code %u)\n", 1825 - type, code); 1823 + pr_err("input_set_capability: unknown type %u (code %u)\n", 1824 + type, code); 1826 1825 dump_stack(); 1827 1826 return; 1828 1827 } ··· 1903 1904 return error; 1904 1905 1905 1906 path = kobject_get_path(&dev->dev.kobj, GFP_KERNEL); 1906 - printk(KERN_INFO "input: %s as %s\n", 1907 - dev->name ? dev->name : "Unspecified device", path ? path : "N/A"); 1907 + pr_info("%s as %s\n", 1908 + dev->name ? dev->name : "Unspecified device", 1909 + path ? path : "N/A"); 1908 1910 kfree(path); 1909 1911 1910 1912 error = mutex_lock_interruptible(&input_mutex); ··· 2187 2187 2188 2188 err = class_register(&input_class); 2189 2189 if (err) { 2190 - printk(KERN_ERR "input: unable to register input_dev class\n"); 2190 + pr_err("unable to register input_dev class\n"); 2191 2191 return err; 2192 2192 } 2193 2193 ··· 2197 2197 2198 2198 err = register_chrdev(INPUT_MAJOR, "input", &input_fops); 2199 2199 if (err) { 2200 - printk(KERN_ERR "input: unable to register char major %d", INPUT_MAJOR); 2200 + pr_err("unable to register char major %d", INPUT_MAJOR); 2201 2201 goto fail2; 2202 2202 } 2203 2203
+3 -1
drivers/input/joydev.c
··· 10 10 * (at your option) any later version. 11 11 */ 12 12 13 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 14 + 13 15 #include <asm/io.h> 14 16 #include <asm/system.h> 15 17 #include <linux/delay.h> ··· 808 806 break; 809 807 810 808 if (minor == JOYDEV_MINORS) { 811 - printk(KERN_ERR "joydev: no more free joydev devices\n"); 809 + pr_err("no more free joydev devices\n"); 812 810 return -ENFILE; 813 811 } 814 812
+6 -4
drivers/input/mousedev.c
··· 9 9 * the Free Software Foundation. 10 10 */ 11 11 12 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 13 + 12 14 #define MOUSEDEV_MINOR_BASE 32 13 15 #define MOUSEDEV_MINORS 32 14 16 #define MOUSEDEV_MIX 31 ··· 979 977 break; 980 978 981 979 if (minor == MOUSEDEV_MINORS) { 982 - printk(KERN_ERR "mousedev: no more free mousedev devices\n"); 980 + pr_err("no more free mousedev devices\n"); 983 981 return -ENFILE; 984 982 } 985 983 ··· 1089 1087 #ifdef CONFIG_INPUT_MOUSEDEV_PSAUX 1090 1088 error = misc_register(&psaux_mouse); 1091 1089 if (error) 1092 - printk(KERN_WARNING "mice: could not register psaux device, " 1093 - "error: %d\n", error); 1090 + pr_warning("could not register psaux device, error: %d\n", 1091 + error); 1094 1092 else 1095 1093 psaux_registered = 1; 1096 1094 #endif 1097 1095 1098 - printk(KERN_INFO "mice: PS/2 mouse device common for all mice\n"); 1096 + pr_info("PS/2 mouse device common for all mice\n"); 1099 1097 1100 1098 return 0; 1101 1099 }
+5 -5
drivers/input/xen-kbdfront.c
··· 17 17 * Switch to grant tables together with xen-fbfront.c. 18 18 */ 19 19 20 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 21 + 20 22 #include <linux/kernel.h> 21 23 #include <linux/errno.h> 22 24 #include <linux/module.h> ··· 86 84 input_report_key(dev, event->key.keycode, 87 85 event->key.pressed); 88 86 else 89 - printk(KERN_WARNING 90 - "xenkbd: unhandled keycode 0x%x\n", 91 - event->key.keycode); 87 + pr_warning("unhandled keycode 0x%x\n", 88 + event->key.keycode); 92 89 break; 93 90 case XENKBD_TYPE_POS: 94 91 input_report_abs(dev, ABS_X, event->pos.abs_x); ··· 293 292 ret = xenbus_printf(XBT_NIL, info->xbdev->nodename, 294 293 "request-abs-pointer", "1"); 295 294 if (ret) 296 - printk(KERN_WARNING 297 - "xenkbd: can't request abs-pointer"); 295 + pr_warning("can't request abs-pointer\n"); 298 296 } 299 297 xenbus_switch_state(dev, XenbusStateConnected); 300 298 break;