Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

misc: bcm-vk: fix tty registration race

Make sure to set the tty class-device driver data before registering the
tty to avoid having a racing open() dereference a NULL pointer.

Fixes: 91ca10d6fa07 ("misc: bcm-vk: add ttyVK support")
Cc: stable@vger.kernel.org # 5.12
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20210917115736.5816-1-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Johan Hovold and committed by
Greg Kroah-Hartman
d9d1232b 50c7ad36

+3 -3
+3 -3
drivers/misc/bcm-vk/bcm_vk_tty.c
··· 267 267 struct device *tty_dev; 268 268 269 269 tty_port_init(&vk->tty[i].port); 270 - tty_dev = tty_port_register_device(&vk->tty[i].port, tty_drv, 271 - i, dev); 270 + tty_dev = tty_port_register_device_attr(&vk->tty[i].port, 271 + tty_drv, i, dev, vk, 272 + NULL); 272 273 if (IS_ERR(tty_dev)) { 273 274 err = PTR_ERR(tty_dev); 274 275 goto unwind; 275 276 } 276 - dev_set_drvdata(tty_dev, vk); 277 277 vk->tty[i].is_opened = false; 278 278 } 279 279