Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf/core: Restore mmap record type correctly

On mmap(), perf_events generates a RECORD_MMAP record and then checks
which events are interested in this record. There are currently 2
versions of mmap records: RECORD_MMAP and RECORD_MMAP2. MMAP2 is larger.
The event configuration controls which version the user level tool
accepts.

If the event->attr.mmap2=1 field then MMAP2 record is returned. The
perf_event_mmap_output() takes care of this. It checks attr->mmap2 and
corrects the record fields before putting it in the sampling buffer of
the event. At the end the function restores the modified MMAP record
fields.

The problem is that the function restores the size but not the type.
Thus, if a subsequent event only accepts MMAP type, then it would
instead receive an MMAP2 record with a size of MMAP record.

This patch fixes the problem by restoring the record type on exit.

Signed-off-by: Stephane Eranian <eranian@google.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Fixes: 13d7a2410fa6 ("perf: Add attr->mmap2 attribute to an event")
Link: http://lkml.kernel.org/r/20190307185233.225521-1-eranian@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

Stephane Eranian and committed by
Arnaldo Carvalho de Melo
d9c1bb2f b339da48

+2
+2
kernel/events/core.c
··· 7189 7189 struct perf_output_handle handle; 7190 7190 struct perf_sample_data sample; 7191 7191 int size = mmap_event->event_id.header.size; 7192 + u32 type = mmap_event->event_id.header.type; 7192 7193 int ret; 7193 7194 7194 7195 if (!perf_event_mmap_match(event, data)) ··· 7233 7232 perf_output_end(&handle); 7234 7233 out: 7235 7234 mmap_event->event_id.header.size = size; 7235 + mmap_event->event_id.header.type = type; 7236 7236 } 7237 7237 7238 7238 static void perf_event_mmap_event(struct perf_mmap_event *mmap_event)