Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

USB: serial: add missing newlines to dev_<level> messages.

Add missing newlines to dev_<level> messages.

Also make some messages less verbose where appropriate.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

authored by

Johan Hovold and committed by
Greg Kroah-Hartman
d9a38a87 ca0400d2

+28 -30
+3 -3
drivers/usb/serial/ch341.c
··· 323 323 if (r) 324 324 goto out; 325 325 326 - dev_dbg(&port->dev, "%s - submitting interrupt urb", __func__); 326 + dev_dbg(&port->dev, "%s - submitting interrupt urb\n", __func__); 327 327 r = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); 328 328 if (r) { 329 - dev_err(&port->dev, "%s - failed submitting interrupt urb," 330 - " error %d\n", __func__, r); 329 + dev_err(&port->dev, "%s - failed to submit interrupt urb: %d\n", 330 + __func__, r); 331 331 ch341_close(port); 332 332 goto out; 333 333 }
+1 -1
drivers/usb/serial/cyberjack.c
··· 220 220 result = usb_submit_urb(port->write_urb, GFP_ATOMIC); 221 221 if (result) { 222 222 dev_err(&port->dev, 223 - "%s - failed submitting write urb, error %d", 223 + "%s - failed submitting write urb, error %d\n", 224 224 __func__, result); 225 225 /* Throw away data. No better idea what to do with it. */ 226 226 priv->wrfilled = 0;
+1 -1
drivers/usb/serial/cypress_m8.c
··· 279 279 * the generic firmware, but are not used with 280 280 * NMEA and SiRF protocols */ 281 281 dev_dbg(&port->dev, 282 - "%s - failed setting baud rate, unsupported speed of %d on Earthmate GPS", 282 + "%s - failed setting baud rate, unsupported speed of %d on Earthmate GPS\n", 283 283 __func__, new_rate); 284 284 return -1; 285 285 }
+1 -1
drivers/usb/serial/iuu_phoenix.c
··· 1151 1151 goto fail_store_vcc_mode; 1152 1152 } 1153 1153 1154 - dev_dbg(dev, "%s: setting vcc_mode = %ld", __func__, v); 1154 + dev_dbg(dev, "%s: setting vcc_mode = %ld\n", __func__, v); 1155 1155 1156 1156 if ((v != 3) && (v != 5)) { 1157 1157 dev_err(dev, "%s - vcc_mode %ld is invalid\n", __func__, v);
+1 -1
drivers/usb/serial/keyspan_pda.c
··· 189 189 retval = usb_submit_urb(urb, GFP_ATOMIC); 190 190 if (retval) 191 191 dev_err(&port->dev, 192 - "%s - usb_submit_urb failed with result %d", 192 + "%s - usb_submit_urb failed with result %d\n", 193 193 __func__, retval); 194 194 } 195 195
+2 -2
drivers/usb/serial/kl5kusb105.c
··· 201 201 else { 202 202 status = get_unaligned_le16(status_buf); 203 203 204 - dev_info(&port->serial->dev->dev, "read status %x %x", 204 + dev_info(&port->serial->dev->dev, "read status %x %x\n", 205 205 status_buf[0], status_buf[1]); 206 206 207 207 *line_state_p = klsi_105_status2linestate(status); ··· 464 464 priv->cfg.baudrate = kl5kusb105a_sio_b115200; 465 465 break; 466 466 default: 467 - dev_dbg(dev, "KLSI USB->Serial converter: unsupported baudrate request, using default of 9600"); 467 + dev_dbg(dev, "unsupported baudrate, using 9600\n"); 468 468 priv->cfg.baudrate = kl5kusb105a_sio_b9600; 469 469 baud = 9600; 470 470 break;
+2 -1
drivers/usb/serial/kobil_sct.c
··· 557 557 ); 558 558 559 559 dev_dbg(&port->dev, 560 - "%s - Send reset_all_queues (FLUSH) URB returns: %i", __func__, result); 560 + "%s - Send reset_all_queues (FLUSH) URB returns: %i\n", 561 + __func__, result); 561 562 kfree(transfer_buffer); 562 563 return (result < 0) ? -EIO: 0; 563 564 default:
+6 -6
drivers/usb/serial/mos7720.c
··· 209 209 index, NULL, 0, MOS_WDR_TIMEOUT); 210 210 if (status < 0) 211 211 dev_err(&usbdev->dev, 212 - "mos7720: usb_control_msg() failed: %d", status); 212 + "mos7720: usb_control_msg() failed: %d\n", status); 213 213 return status; 214 214 } 215 215 ··· 240 240 *data = *buf; 241 241 else if (status < 0) 242 242 dev_err(&usbdev->dev, 243 - "mos7720: usb_control_msg() failed: %d", status); 243 + "mos7720: usb_control_msg() failed: %d\n", status); 244 244 kfree(buf); 245 245 246 246 return status; ··· 399 399 &mos_parport->deferred_urbs); 400 400 spin_unlock_irqrestore(&mos_parport->listlock, flags); 401 401 tasklet_schedule(&mos_parport->urb_tasklet); 402 - dev_dbg(&usbdev->dev, "tasklet scheduled"); 402 + dev_dbg(&usbdev->dev, "tasklet scheduled\n"); 403 403 return 0; 404 404 } 405 405 ··· 418 418 mutex_unlock(&serial->disc_mutex); 419 419 if (ret_val) { 420 420 dev_err(&usbdev->dev, 421 - "%s: submit_urb() failed: %d", __func__, ret_val); 421 + "%s: submit_urb() failed: %d\n", __func__, ret_val); 422 422 spin_lock_irqsave(&mos_parport->listlock, flags); 423 423 list_del(&urbtrack->urblist_entry); 424 424 spin_unlock_irqrestore(&mos_parport->listlock, flags); ··· 656 656 parport_epilogue(pp); 657 657 if (retval) { 658 658 dev_err(&mos_parport->serial->dev->dev, 659 - "mos7720: usb_bulk_msg() failed: %d", retval); 659 + "mos7720: usb_bulk_msg() failed: %d\n", retval); 660 660 return 0; 661 661 } 662 662 return actual_len; ··· 875 875 if (!(iir & 0x01)) { /* serial port interrupt pending */ 876 876 switch (iir & 0x0f) { 877 877 case SERIAL_IIR_RLS: 878 - dev_dbg(dev, "Serial Port: Receiver status error or address bit detected in 9-bit mode\n\n"); 878 + dev_dbg(dev, "Serial Port: Receiver status error or address bit detected in 9-bit mode\n"); 879 879 break; 880 880 case SERIAL_IIR_CTI: 881 881 dev_dbg(dev, "Serial Port: Receiver time out\n");
+2 -2
drivers/usb/serial/mos7840.c
··· 522 522 case -ENOENT: 523 523 case -ESHUTDOWN: 524 524 /* This urb is terminated, clean up */ 525 - dev_dbg(&urb->dev->dev, "%s - urb shutting down with status: %d", 525 + dev_dbg(&urb->dev->dev, "%s - urb shutting down: %d\n", 526 526 __func__, urb->status); 527 527 break; 528 528 default: 529 - dev_dbg(&urb->dev->dev, "%s - nonzero urb status received: %d", 529 + dev_dbg(&urb->dev->dev, "%s - nonzero urb status: %d\n", 530 530 __func__, urb->status); 531 531 } 532 532 }
+1 -1
drivers/usb/serial/quatech2.c
··· 372 372 device_port, data, 2, QT2_USB_TIMEOUT); 373 373 374 374 if (status < 0) { 375 - dev_err(&port->dev, "%s - open port failed %i", __func__, 375 + dev_err(&port->dev, "%s - open port failed %i\n", __func__, 376 376 status); 377 377 kfree(data); 378 378 return status;
+3 -4
drivers/usb/serial/spcp8x5.c
··· 220 220 GET_UART_STATUS, GET_UART_STATUS_TYPE, 221 221 0, GET_UART_STATUS_MSR, buf, 1, 100); 222 222 if (ret < 0) 223 - dev_err(&port->dev, "failed to get modem status: %d", ret); 223 + dev_err(&port->dev, "failed to get modem status: %d\n", ret); 224 224 225 - dev_dbg(&port->dev, "0xc0:0x22:0:6 %d - 0x02%x", ret, *buf); 225 + dev_dbg(&port->dev, "0xc0:0x22:0:6 %d - 0x02%x\n", ret, *buf); 226 226 *status = *buf; 227 227 kfree(buf); 228 228 ··· 342 342 case 1000000: 343 343 buf[0] = 0x0b; break; 344 344 default: 345 - dev_err(&port->dev, "spcp825 driver does not support the " 346 - "baudrate requested, using default of 9600.\n"); 345 + dev_err(&port->dev, "unsupported baudrate, using 9600\n"); 347 346 } 348 347 349 348 /* Set Data Length : 00:5bit, 01:6bit, 10:7bit, 11:8bit */
+1 -3
drivers/usb/serial/symbolserial.c
··· 74 74 tty_insert_flip_string(&port->port, &data[1], data_length); 75 75 tty_flip_buffer_push(&port->port); 76 76 } else { 77 - dev_dbg(&port->dev, 78 - "Improper amount of data received from the device, " 79 - "%d bytes", urb->actual_length); 77 + dev_dbg(&port->dev, "%s - short packet\n", __func__); 80 78 } 81 79 82 80 exit:
+2 -2
drivers/usb/serial/ti_usb_3410_5052.c
··· 293 293 int status; 294 294 295 295 dev_dbg(&dev->dev, 296 - "%s - product 0x%4X, num configurations %d, configuration value %d", 296 + "%s - product 0x%4X, num configurations %d, configuration value %d\n", 297 297 __func__, le16_to_cpu(dev->descriptor.idProduct), 298 298 dev->descriptor.bNumConfigurations, 299 299 dev->actconfig->desc.bConfigurationValue); ··· 803 803 tty_encode_baud_rate(tty, baud, baud); 804 804 805 805 dev_dbg(&port->dev, 806 - "%s - BaudRate=%d, wBaudRate=%d, wFlags=0x%04X, bDataBits=%d, bParity=%d, bStopBits=%d, cXon=%d, cXoff=%d, bUartMode=%d", 806 + "%s - BaudRate=%d, wBaudRate=%d, wFlags=0x%04X, bDataBits=%d, bParity=%d, bStopBits=%d, cXon=%d, cXoff=%d, bUartMode=%d\n", 807 807 __func__, baud, config->wBaudRate, config->wFlags, 808 808 config->bDataBits, config->bParity, config->bStopBits, 809 809 config->cXon, config->cXoff, config->bUartMode);
+2 -2
drivers/usb/serial/usb-serial.c
··· 868 868 max_endpoints = max(max_endpoints, (int)serial->num_ports); 869 869 serial->num_port_pointers = max_endpoints; 870 870 871 - dev_dbg(ddev, "setting up %d port structures for this device", max_endpoints); 871 + dev_dbg(ddev, "setting up %d port structure(s)\n", max_endpoints); 872 872 for (i = 0; i < max_endpoints; ++i) { 873 873 port = kzalloc(sizeof(struct usb_serial_port), GFP_KERNEL); 874 874 if (!port) ··· 1033 1033 for (i = 0; i < num_ports; ++i) { 1034 1034 port = serial->port[i]; 1035 1035 dev_set_name(&port->dev, "ttyUSB%d", port->minor); 1036 - dev_dbg(ddev, "registering %s", dev_name(&port->dev)); 1036 + dev_dbg(ddev, "registering %s\n", dev_name(&port->dev)); 1037 1037 device_enable_async_suspend(&port->dev); 1038 1038 1039 1039 retval = device_add(&port->dev);