Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm: omap: Rely on the default ->best_encoder() behavior

We have a 1:1 relationship between connectors and encoders and the
driver is relying on the atomic helpers: we can drop the custom
->best_encoder() implementation and let the core call
drm_atomic_helper_best_encoder() for us.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1465300095-16971-17-git-send-email-boris.brezillon@free-electrons.com

authored by

Boris Brezillon and committed by
Daniel Vetter
d9991f45 a50dcc50

-10
-10
drivers/gpu/drm/omapdrm/omap_connector.c
··· 32 32 struct omap_connector { 33 33 struct drm_connector base; 34 34 struct omap_dss_device *dssdev; 35 - struct drm_encoder *encoder; 36 35 bool hdmi_mode; 37 36 }; 38 37 ··· 255 256 return ret; 256 257 } 257 258 258 - struct drm_encoder *omap_connector_attached_encoder( 259 - struct drm_connector *connector) 260 - { 261 - struct omap_connector *omap_connector = to_omap_connector(connector); 262 - return omap_connector->encoder; 263 - } 264 - 265 259 static const struct drm_connector_funcs omap_connector_funcs = { 266 260 .dpms = drm_atomic_helper_connector_dpms, 267 261 .reset = drm_atomic_helper_connector_reset, ··· 268 276 static const struct drm_connector_helper_funcs omap_connector_helper_funcs = { 269 277 .get_modes = omap_connector_get_modes, 270 278 .mode_valid = omap_connector_mode_valid, 271 - .best_encoder = omap_connector_attached_encoder, 272 279 }; 273 280 274 281 /* initialize connector */ ··· 287 296 goto fail; 288 297 289 298 omap_connector->dssdev = dssdev; 290 - omap_connector->encoder = encoder; 291 299 292 300 connector = &omap_connector->base; 293 301