Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/crc-debugfs: Also sprinkle irqrestore over early exits

I. was. blind.

Caught with vkms, which has some really slow crc computation function.

Fixes: 1882018a70e0 ("drm/crc-debugfs: User irqsafe spinlock in drm_crtc_add_crc_entry")
Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: Emil Velikov <emil.velikov@collabora.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190606211544.5389-1-daniel.vetter@ffwll.ch

+2 -2
+2 -2
drivers/gpu/drm/drm_debugfs_crc.c
··· 402 402 403 403 /* Caller may not have noticed yet that userspace has stopped reading */ 404 404 if (!crc->entries) { 405 - spin_unlock(&crc->lock); 405 + spin_unlock_irqrestore(&crc->lock, flags); 406 406 return -EINVAL; 407 407 } 408 408 ··· 413 413 bool was_overflow = crc->overflow; 414 414 415 415 crc->overflow = true; 416 - spin_unlock(&crc->lock); 416 + spin_unlock_irqrestore(&crc->lock, flags); 417 417 418 418 if (!was_overflow) 419 419 DRM_ERROR("Overflow of CRC buffer, userspace reads too slow.\n");