···309309static void butterfly_detach(struct parport *p)310310{311311 struct butterfly *pp;312312- int status;313312314313 /* FIXME this global is ugly ... but, how to quickly get from315314 * the parport to the "struct butterfly" associated with it?···320321 butterfly = NULL;321322322323 /* stop() unregisters child devices too */323323- status = spi_bitbang_stop(&pp->bitbang);324324+ spi_bitbang_stop(&pp->bitbang);324325325326 /* turn off VCC */326327 parport_write_data(pp->port, 0);
+2-3
drivers/spi/spi-gpio.c
···503503{504504 struct spi_gpio *spi_gpio;505505 struct spi_gpio_platform_data *pdata;506506- int status;507506508507 spi_gpio = platform_get_drvdata(pdev);509508 pdata = dev_get_platdata(&pdev->dev);510509511510 /* stop() unregisters child devices too */512512- status = spi_bitbang_stop(&spi_gpio->bitbang);511511+ spi_bitbang_stop(&spi_gpio->bitbang);513512514513 if (SPI_MISO_GPIO != SPI_GPIO_NO_MISO)515514 gpio_free(SPI_MISO_GPIO);···517518 gpio_free(SPI_SCK_GPIO);518519 spi_master_put(spi_gpio->bitbang.master);519520520520- return status;521521+ return 0;521522}522523523524MODULE_ALIAS("platform:" DRIVER_NAME);
+2-3
drivers/spi/spi-omap-uwire.c
···539539static int uwire_remove(struct platform_device *pdev)540540{541541 struct uwire_spi *uwire = platform_get_drvdata(pdev);542542- int status;543542544543 // FIXME remove all child devices, somewhere ...545544546546- status = spi_bitbang_stop(&uwire->bitbang);545545+ spi_bitbang_stop(&uwire->bitbang);547546 uwire_off(uwire);548547 iounmap(uwire_base);549549- return status;548548+ return 0;550549}551550552551/* work with hotplug and coldplug */
+1-1
include/linux/spi/spi_bitbang.h
···42424343/* start or stop queue processing */4444extern int spi_bitbang_start(struct spi_bitbang *spi);4545-extern int spi_bitbang_stop(struct spi_bitbang *spi);4545+extern void spi_bitbang_stop(struct spi_bitbang *spi);46464747#endif /* __SPI_BITBANG_H */