Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: starfive: jh7110-vout: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/90054b8b2e118bc04ec37e044d0ac518bb177cf4.1709721042.git.u.kleine-koenig@pengutronix.de
Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

authored by

Uwe Kleine-König and committed by
Stephen Boyd
d963f257 4421d8b5

+2 -4
+2 -4
drivers/clk/starfive/clk-starfive-jh7110-vout.c
··· 209 209 return ret; 210 210 } 211 211 212 - static int jh7110_voutcrg_remove(struct platform_device *pdev) 212 + static void jh7110_voutcrg_remove(struct platform_device *pdev) 213 213 { 214 214 pm_runtime_put_sync(&pdev->dev); 215 215 pm_runtime_disable(&pdev->dev); 216 - 217 - return 0; 218 216 } 219 217 220 218 static const struct of_device_id jh7110_voutcrg_match[] = { ··· 223 225 224 226 static struct platform_driver jh7110_voutcrg_driver = { 225 227 .probe = jh7110_voutcrg_probe, 226 - .remove = jh7110_voutcrg_remove, 228 + .remove_new = jh7110_voutcrg_remove, 227 229 .driver = { 228 230 .name = "clk-starfive-jh7110-vout", 229 231 .of_match_table = jh7110_voutcrg_match,