Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pinctrl: mcp23s08: drop comment about missing irq support

The driver supports using mcp23xxx as interrupt controller, so
let's drop all comments stating otherwise.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Sebastian Reichel and committed by
Linus Walleij
d8f4494e ce9bd0a0

+2 -20
+2 -17
drivers/pinctrl/pinctrl-mcp23s08.c
··· 1 - /* 2 - * MCP23S08 SPI/I2C GPIO gpio expander driver 3 - * 4 - * The inputs and outputs of the mcp23s08, mcp23s17, mcp23008 and mcp23017 are 5 - * supported. 6 - * For the I2C versions of the chips (mcp23008 and mcp23017) generation of 7 - * interrupts is also supported. 8 - * The hardware of the SPI versions of the chips (mcp23s08 and mcp23s17) is 9 - * also capable of generating interrupts, but the linux driver does not 10 - * support that yet. 11 - */ 1 + /* MCP23S08 SPI/I2C GPIO driver */ 12 2 13 3 #include <linux/kernel.h> 14 4 #include <linux/device.h> ··· 17 27 #include <linux/pinctrl/pinconf.h> 18 28 #include <linux/pinctrl/pinconf-generic.h> 19 29 20 - /** 30 + /* 21 31 * MCP types supported by driver 22 32 */ 23 33 #define MCP_TYPE_S08 0 ··· 1120 1130 ngpio += data->mcp[addr]->chip.ngpio; 1121 1131 } 1122 1132 data->ngpio = ngpio; 1123 - 1124 - /* NOTE: these chips have a relatively sane IRQ framework, with 1125 - * per-signal masking and level/edge triggering. It's not yet 1126 - * handled here... 1127 - */ 1128 1133 1129 1134 return 0; 1130 1135 }
-3
include/linux/spi/mcp23s08.h
··· 1 - 2 - /* FIXME driver should be able to handle IRQs... */ 3 - 4 1 struct mcp23s08_platform_data { 5 2 /* For mcp23s08, up to 4 slaves (numbered 0..3) can share one SPI 6 3 * chipselect, each providing 1 gpio_chip instance with 8 gpios.