Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

nfsd4: remove ACE4_IDENTIFIER_GROUP flag from GROUP@ entry

RFC 3530 says "ACE4_IDENTIFIER_GROUP flag MUST be ignored on entries
with these special identifiers. When encoding entries with these
special identifiers, the ACE4_IDENTIFIER_GROUP flag SHOULD be set to
zero." It really shouldn't matter either way, but the point is that
this flag is used to distinguish named users from named groups (since
unix allows a group to have the same name as a user), so it doesn't
really make sense to use it on a special identifier such as this.)

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>

authored by

Frank Filz and committed by
J. Bruce Fields
d8d0b85b b0401d72

+1 -1
+1 -1
fs/nfsd/nfs4acl.c
··· 321 321 deny = ~pas.group & pas.other; 322 322 if (deny) { 323 323 ace->type = NFS4_ACE_ACCESS_DENIED_ACE_TYPE; 324 - ace->flag = eflag | NFS4_ACE_IDENTIFIER_GROUP; 324 + ace->flag = eflag; 325 325 ace->access_mask = deny_mask_from_posix(deny, flags); 326 326 ace->whotype = NFS4_ACL_WHO_GROUP; 327 327 ace++;