[PATCH] m68k: dsp56k __user annotations

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: Roman Zippel <zippel@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by Al Viro and committed by Linus Torvalds d85f6891 ab14caec

+16 -15
+15 -14
drivers/char/dsp56k.c
··· 165 return 0; 166 } 167 168 - static int dsp56k_upload(u_char *bin, int len) 169 { 170 int i; 171 u_char *p; ··· 199 return 0; 200 } 201 202 - static ssize_t dsp56k_read(struct file *file, char *buf, size_t count, 203 loff_t *ppos) 204 { 205 struct inode *inode = file->f_dentry->d_inode; ··· 225 } 226 case 2: /* 16 bit */ 227 { 228 - short *data; 229 230 count /= 2; 231 - data = (short*) buf; 232 handshake(count, dsp56k.maxio, dsp56k.timeout, DSP56K_RECEIVE, 233 put_user(dsp56k_host_interface.data.w[1], data+n++)); 234 return 2*n; ··· 244 } 245 case 4: /* 32 bit */ 246 { 247 - long *data; 248 249 count /= 4; 250 - data = (long*) buf; 251 handshake(count, dsp56k.maxio, dsp56k.timeout, DSP56K_RECEIVE, 252 put_user(dsp56k_host_interface.data.l, data+n++)); 253 return 4*n; ··· 262 } 263 } 264 265 - static ssize_t dsp56k_write(struct file *file, const char *buf, size_t count, 266 loff_t *ppos) 267 { 268 struct inode *inode = file->f_dentry->d_inode; ··· 287 } 288 case 2: /* 16 bit */ 289 { 290 - const short *data; 291 292 count /= 2; 293 - data = (const short *)buf; 294 handshake(count, dsp56k.maxio, dsp56k.timeout, DSP56K_TRANSMIT, 295 get_user(dsp56k_host_interface.data.w[1], data+n++)); 296 return 2*n; ··· 306 } 307 case 4: /* 32 bit */ 308 { 309 - const long *data; 310 311 count /= 4; 312 - data = (const long *)buf; 313 handshake(count, dsp56k.maxio, dsp56k.timeout, DSP56K_TRANSMIT, 314 get_user(dsp56k_host_interface.data.l, data+n++)); 315 return 4*n; ··· 328 unsigned int cmd, unsigned long arg) 329 { 330 int dev = iminor(inode) & 0x0f; 331 332 switch(dev) 333 { ··· 337 switch(cmd) { 338 case DSP56K_UPLOAD: 339 { 340 - char *bin; 341 int r, len; 342 - struct dsp56k_upload *binary = (struct dsp56k_upload *) arg; 343 344 if(get_user(len, &binary->len) < 0) 345 return -EFAULT; ··· 373 case DSP56K_HOST_FLAGS: 374 { 375 int dir, out, status; 376 - struct dsp56k_host_flags *hf = (struct dsp56k_host_flags*) arg; 377 378 if(get_user(dir, &hf->dir) < 0) 379 return -EFAULT;
··· 165 return 0; 166 } 167 168 + static int dsp56k_upload(u_char __user *bin, int len) 169 { 170 int i; 171 u_char *p; ··· 199 return 0; 200 } 201 202 + static ssize_t dsp56k_read(struct file *file, char __user *buf, size_t count, 203 loff_t *ppos) 204 { 205 struct inode *inode = file->f_dentry->d_inode; ··· 225 } 226 case 2: /* 16 bit */ 227 { 228 + short __user *data; 229 230 count /= 2; 231 + data = (short __user *) buf; 232 handshake(count, dsp56k.maxio, dsp56k.timeout, DSP56K_RECEIVE, 233 put_user(dsp56k_host_interface.data.w[1], data+n++)); 234 return 2*n; ··· 244 } 245 case 4: /* 32 bit */ 246 { 247 + long __user *data; 248 249 count /= 4; 250 + data = (long __user *) buf; 251 handshake(count, dsp56k.maxio, dsp56k.timeout, DSP56K_RECEIVE, 252 put_user(dsp56k_host_interface.data.l, data+n++)); 253 return 4*n; ··· 262 } 263 } 264 265 + static ssize_t dsp56k_write(struct file *file, const char __user *buf, size_t count, 266 loff_t *ppos) 267 { 268 struct inode *inode = file->f_dentry->d_inode; ··· 287 } 288 case 2: /* 16 bit */ 289 { 290 + const short __user *data; 291 292 count /= 2; 293 + data = (const short __user *)buf; 294 handshake(count, dsp56k.maxio, dsp56k.timeout, DSP56K_TRANSMIT, 295 get_user(dsp56k_host_interface.data.w[1], data+n++)); 296 return 2*n; ··· 306 } 307 case 4: /* 32 bit */ 308 { 309 + const long __user *data; 310 311 count /= 4; 312 + data = (const long __user *)buf; 313 handshake(count, dsp56k.maxio, dsp56k.timeout, DSP56K_TRANSMIT, 314 get_user(dsp56k_host_interface.data.l, data+n++)); 315 return 4*n; ··· 328 unsigned int cmd, unsigned long arg) 329 { 330 int dev = iminor(inode) & 0x0f; 331 + void __user *argp = (void __user *)arg; 332 333 switch(dev) 334 { ··· 336 switch(cmd) { 337 case DSP56K_UPLOAD: 338 { 339 + char __user *bin; 340 int r, len; 341 + struct dsp56k_upload __user *binary = argp; 342 343 if(get_user(len, &binary->len) < 0) 344 return -EFAULT; ··· 372 case DSP56K_HOST_FLAGS: 373 { 374 int dir, out, status; 375 + struct dsp56k_host_flags __user *hf = argp; 376 377 if(get_user(dir, &hf->dir) < 0) 378 return -EFAULT;
+1 -1
include/asm-m68k/dsp56k.h
··· 13 /* Used for uploading DSP binary code */ 14 struct dsp56k_upload { 15 int len; 16 - char *bin; 17 }; 18 19 /* For the DSP host flags */
··· 13 /* Used for uploading DSP binary code */ 14 struct dsp56k_upload { 15 int len; 16 + char __user *bin; 17 }; 18 19 /* For the DSP host flags */