net: phy: sfp: correct store of detected link modes

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

The link modes that sfp_parse_support() detects are stored in the
'modes' bitmap. There is no reason to make an exception for 1000Base-PX
or 1000Base-BX10.

Fixes: 03145864bd0f ("sfp: support 1G BiDi (eg, FiberStore SFP-GE-BX) modules")
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Baruch Siach and committed by

David S. Miller 7 years ago d7f7e001 f1c0f591

+1 -1

1 changed file

expand all

drivers

net

phy

sfp-bus.c

+1 -1

drivers/net/phy/sfp-bus.c

··· 162 162 /* 1000Base-PX or 1000Base-BX10 */ 163 163 if ((id->base.e_base_px || id->base.e_base_bx10) && 164 164 br_min <= 1300 && br_max >= 1200) 165 - phylink_set(support, 1000baseX_Full); 165 + phylink_set(modes, 1000baseX_Full); 166 166 167 167 /* For active or passive cables, select the link modes 168 168 * based on the bit rates and the cable compliance bytes.