tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

dmaengine: at_hdmac: fix way to specify cyclic capability

In this driver, we can trigger cyclic transfer on peripherals-DMA interfaces.
It is dependent on driver implementation but cannot depend on a platform
property: we remove the dma_has_cap(DMA_CYCLIC, ) test which has no meaning.

Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

authored by

Nicolas Ferre and committed by
Vinod Koul d7db8080 3c477482

+4 -6
+4 -6
drivers/dma/at_hdmac.c
··· 1301 1301 if (dma_has_cap(DMA_MEMCPY, atdma->dma_common.cap_mask)) 1302 1302 atdma->dma_common.device_prep_dma_memcpy = atc_prep_dma_memcpy; 1303 1303 1304 - if (dma_has_cap(DMA_SLAVE, atdma->dma_common.cap_mask)) 1304 + if (dma_has_cap(DMA_SLAVE, atdma->dma_common.cap_mask)) { 1305 1305 atdma->dma_common.device_prep_slave_sg = atc_prep_slave_sg; 1306 - 1307 - if (dma_has_cap(DMA_CYCLIC, atdma->dma_common.cap_mask)) 1306 + /* controller can do slave DMA: can trigger cyclic transfers */ 1307 + dma_cap_set(DMA_CYCLIC, atdma->dma_common.cap_mask); 1308 1308 atdma->dma_common.device_prep_dma_cyclic = atc_prep_dma_cyclic; 1309 - 1310 - if (dma_has_cap(DMA_SLAVE, atdma->dma_common.cap_mask) || 1311 - dma_has_cap(DMA_CYCLIC, atdma->dma_common.cap_mask)) 1312 1309 atdma->dma_common.device_control = atc_control; 1310 + } 1313 1311 1314 1312 dma_writel(atdma, EN, AT_DMA_ENABLE); 1315 1313