Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ext4: add missing KERN_CONT to a few more debugging uses

Recent commits require line continuing printks to always use
pr_cont or KERN_CONT. Add these markings to a few more printks.

Miscellaneaous:

o Integrate the ea_idebug and ea_bdebug macros to use a single
call to printk(KERN_DEBUG instead of 3 separate printks
o Use the more common varargs macro style

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>

authored by

Joe Perches and committed by
Theodore Ts'o
d74f3d25 8906a822

+26 -31
+2 -2
fs/ext4/block_validity.c
··· 128 128 node = rb_first(&sbi->system_blks); 129 129 while (node) { 130 130 entry = rb_entry(node, struct ext4_system_zone, node); 131 - printk("%s%llu-%llu", first ? "" : ", ", 131 + printk(KERN_CONT "%s%llu-%llu", first ? "" : ", ", 132 132 entry->start_blk, entry->start_blk + entry->count - 1); 133 133 first = 0; 134 134 node = rb_next(node); 135 135 } 136 - printk("\n"); 136 + printk(KERN_CONT "\n"); 137 137 } 138 138 139 139 int ext4_setup_system_zone(struct super_block *sb)
+8 -9
fs/ext4/mballoc.h
··· 27 27 #ifdef CONFIG_EXT4_DEBUG 28 28 extern ushort ext4_mballoc_debug; 29 29 30 - #define mb_debug(n, fmt, a...) \ 31 - do { \ 32 - if ((n) <= ext4_mballoc_debug) { \ 33 - printk(KERN_DEBUG "(%s, %d): %s: ", \ 34 - __FILE__, __LINE__, __func__); \ 35 - printk(fmt, ## a); \ 36 - } \ 37 - } while (0) 30 + #define mb_debug(n, fmt, ...) \ 31 + do { \ 32 + if ((n) <= ext4_mballoc_debug) { \ 33 + printk(KERN_DEBUG "(%s, %d): %s: " fmt, \ 34 + __FILE__, __LINE__, __func__, ##__VA_ARGS__); \ 35 + } \ 36 + } while (0) 38 37 #else 39 - #define mb_debug(n, fmt, a...) no_printk(fmt, ## a) 38 + #define mb_debug(n, fmt, ...) no_printk(fmt, ##__VA_ARGS__) 40 39 #endif 41 40 42 41 #define EXT4_MB_HISTORY_ALLOC 1 /* allocation */
+10 -8
fs/ext4/namei.c
··· 577 577 static void dx_show_index(char * label, struct dx_entry *entries) 578 578 { 579 579 int i, n = dx_get_count (entries); 580 - printk(KERN_DEBUG "%s index ", label); 580 + printk(KERN_DEBUG "%s index", label); 581 581 for (i = 0; i < n; i++) { 582 - printk("%x->%lu ", i ? dx_get_hash(entries + i) : 583 - 0, (unsigned long)dx_get_block(entries + i)); 582 + printk(KERN_CONT " %x->%lu", 583 + i ? dx_get_hash(entries + i) : 0, 584 + (unsigned long)dx_get_block(entries + i)); 584 585 } 585 - printk("\n"); 586 + printk(KERN_CONT "\n"); 586 587 } 587 588 588 589 struct stats ··· 680 679 } 681 680 de = ext4_next_entry(de, size); 682 681 } 683 - printk("(%i)\n", names); 682 + printk(KERN_CONT "(%i)\n", names); 684 683 return (struct stats) { names, space, 1 }; 685 684 } 686 685 ··· 799 798 q = entries + count - 1; 800 799 while (p <= q) { 801 800 m = p + (q - p) / 2; 802 - dxtrace(printk(".")); 801 + dxtrace(printk(KERN_CONT ".")); 803 802 if (dx_get_hash(m) > hash) 804 803 q = m - 1; 805 804 else ··· 811 810 at = entries; 812 811 while (n--) 813 812 { 814 - dxtrace(printk(",")); 813 + dxtrace(printk(KERN_CONT ",")); 815 814 if (dx_get_hash(++at) > hash) 816 815 { 817 816 at--; ··· 822 821 } 823 822 824 823 at = p - 1; 825 - dxtrace(printk(" %x->%u\n", at == entries ? 0 : dx_get_hash(at), 824 + dxtrace(printk(KERN_CONT " %x->%u\n", 825 + at == entries ? 0 : dx_get_hash(at), 826 826 dx_get_block(at))); 827 827 frame->entries = entries; 828 828 frame->at = at;
+6 -12
fs/ext4/xattr.c
··· 61 61 #include "acl.h" 62 62 63 63 #ifdef EXT4_XATTR_DEBUG 64 - # define ea_idebug(inode, f...) do { \ 65 - printk(KERN_DEBUG "inode %s:%lu: ", \ 66 - inode->i_sb->s_id, inode->i_ino); \ 67 - printk(f); \ 68 - printk("\n"); \ 69 - } while (0) 70 - # define ea_bdebug(bh, f...) do { \ 71 - printk(KERN_DEBUG "block %pg:%lu: ", \ 72 - bh->b_bdev, (unsigned long) bh->b_blocknr); \ 73 - printk(f); \ 74 - printk("\n"); \ 75 - } while (0) 64 + # define ea_idebug(inode, fmt, ...) \ 65 + printk(KERN_DEBUG "inode %s:%lu: " fmt "\n", \ 66 + inode->i_sb->s_id, inode->i_ino, ##__VA_ARGS__) 67 + # define ea_bdebug(bh, fmt, ...) \ 68 + printk(KERN_DEBUG "block %pg:%lu: " fmt "\n", \ 69 + bh->b_bdev, (unsigned long)bh->b_blocknr, ##__VA_ARGS__) 76 70 #else 77 71 # define ea_idebug(inode, fmt, ...) no_printk(fmt, ##__VA_ARGS__) 78 72 # define ea_bdebug(bh, fmt, ...) no_printk(fmt, ##__VA_ARGS__)