tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
rtc: ep93xx: fix checkpatch issues
Fix sysfs attribute declaration as suggested by checkpatch.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
+9
-9
+9
-9
drivers/rtc/rtc-ep93xx.c
+9
-9
drivers/rtc/rtc-ep93xx.c
···
15
15
#define EP93XX_RTC_DATA 0x000
16
16
#define EP93XX_RTC_MATCH 0x004
17
17
#define EP93XX_RTC_STATUS 0x008
18
-
#define EP93XX_RTC_STATUS_INTR (1<<0)
18
+
#define EP93XX_RTC_STATUS_INTR BIT(0)
19
19
#define EP93XX_RTC_LOAD 0x00C
20
20
#define EP93XX_RTC_CONTROL 0x010
21
-
#define EP93XX_RTC_CONTROL_MIE (1<<0)
21
+
#define EP93XX_RTC_CONTROL_MIE BIT(0)
22
22
#define EP93XX_RTC_SWCOMP 0x108
23
23
#define EP93XX_RTC_SWCOMP_DEL_MASK 0x001f0000
24
24
#define EP93XX_RTC_SWCOMP_DEL_SHIFT 16
···
31
31
};
32
32
33
33
static int ep93xx_rtc_get_swcomp(struct device *dev, unsigned short *preload,
34
-
unsigned short *delete)
34
+
unsigned short *delete)
35
35
{
36
36
struct ep93xx_rtc *ep93xx_rtc = dev_get_platdata(dev);
37
37
unsigned long comp;
···
87
87
.proc = ep93xx_rtc_proc,
88
88
};
89
89
90
-
static ssize_t ep93xx_rtc_show_comp_preload(struct device *dev,
91
-
struct device_attribute *attr, char *buf)
90
+
static ssize_t comp_preload_show(struct device *dev,
91
+
struct device_attribute *attr, char *buf)
92
92
{
93
93
unsigned short preload;
94
94
···
96
96
97
97
return sprintf(buf, "%d\n", preload);
98
98
}
99
-
static DEVICE_ATTR(comp_preload, S_IRUGO, ep93xx_rtc_show_comp_preload, NULL);
99
+
static DEVICE_ATTR_RO(comp_preload);
100
100
101
-
static ssize_t ep93xx_rtc_show_comp_delete(struct device *dev,
102
-
struct device_attribute *attr, char *buf)
101
+
static ssize_t comp_delete_show(struct device *dev,
102
+
struct device_attribute *attr, char *buf)
103
103
{
104
104
unsigned short delete;
105
105
···
107
107
108
108
return sprintf(buf, "%d\n", delete);
109
109
}
110
-
static DEVICE_ATTR(comp_delete, S_IRUGO, ep93xx_rtc_show_comp_delete, NULL);
110
+
static DEVICE_ATTR_RO(comp_delete);
111
111
112
112
static struct attribute *ep93xx_rtc_attrs[] = {
113
113
&dev_attr_comp_preload.attr,