tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ALSA: hda - use WARN_ON_ONCE() for zero-division detection

Replace the zero-division warning message with WARN_ON_ONCE() per the
advice by Linus. This shouldn't happen, but if it happens, it's
possible that the bug happens often due to buggy IRQs.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

Takashi Iwai d6d8bf54 fed08d03

+3 -6
+3 -6
sound/pci/hda/hda_intel.c
··· 1893 1893 1894 1894 if (!bdl_pos_adj[chip->dev_index]) 1895 1895 return 1; /* no delayed ack */ 1896 - if (azx_dev->period_bytes == 0) { 1897 - printk(KERN_WARNING 1898 - "hda-intel: Divide by zero was avoided " 1899 - "in azx_dev->period_bytes.\n"); 1900 - return 0; 1901 - } 1896 + if (WARN_ONCE(!azx_dev->period_bytes, 1897 + "hda-intel: zero azx_dev->period_bytes")) 1898 + return 0; /* this shouldn't happen! */ 1902 1899 if (pos % azx_dev->period_bytes > azx_dev->period_bytes / 2) 1903 1900 return 0; /* NG - it's below the period boundary */ 1904 1901 return 1; /* OK, it's fine */