Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

uprobes/x86: Fix arch_uprobe_disable_step() && UTASK_SSTEP_TRAPPED interaction

arch_uprobe_disable_step() should also take UTASK_SSTEP_TRAPPED into
account. In this case the probed insn was not executed, we need to
clear X86_EFLAGS_TF if it was set by us and that is all.

Again, this code will look more clean when we move it into
arch_uprobe_post_xol() and arch_uprobe_abort_xol().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

+10 -4
+10 -4
arch/x86/kernel/uprobes.c
··· 706 706 { 707 707 struct task_struct *task = current; 708 708 struct arch_uprobe_task *autask = &task->utask->autask; 709 + bool trapped = (task->utask->state == UTASK_SSTEP_TRAPPED); 709 710 struct pt_regs *regs = task_pt_regs(task); 710 711 /* 711 712 * The state of TIF_BLOCKSTEP was not saved so we can get an extra 712 713 * SIGTRAP if we do not clear TF. We need to examine the opcode to 713 714 * make it right. 714 715 */ 715 - if (autask->saved_tf) 716 - send_sig(SIGTRAP, task, 0); 717 - else if (!(auprobe->fixups & UPROBE_FIX_SETF)) 718 - regs->flags &= ~X86_EFLAGS_TF; 716 + if (unlikely(trapped)) { 717 + if (!autask->saved_tf) 718 + regs->flags &= ~X86_EFLAGS_TF; 719 + } else { 720 + if (autask->saved_tf) 721 + send_sig(SIGTRAP, task, 0); 722 + else if (!(auprobe->fixups & UPROBE_FIX_SETF)) 723 + regs->flags &= ~X86_EFLAGS_TF; 724 + } 719 725 }