Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests/powerpc: Use stderr for debug messages in eeh-functions

We want to use stdout to return lists of devices, etc so log debug / status
messages to stderr rather than stdout.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20201103044503.917128-2-oohall@gmail.com

authored by

Oliver O'Halloran and committed by
Michael Ellerman
d6749ccb db82f709

+12 -8
+12 -8
tools/testing/selftests/powerpc/eeh/eeh-functions.sh
··· 3 3 4 4 export KSELFTESTS_SKIP=4 5 5 6 + log() { 7 + echo >/dev/stderr $* 8 + } 9 + 6 10 pe_ok() { 7 11 local dev="$1" 8 12 local path="/sys/bus/pci/devices/$dev/eeh_pe_state" ··· 53 49 54 50 if [ ! -e "/sys/kernel/debug/powerpc/eeh_dev_check" ] && \ 55 51 [ ! -e "/sys/kernel/debug/powerpc/eeh_dev_break" ] ; then 56 - echo "debugfs EEH testing files are missing. Is debugfs mounted?" 52 + log "debugfs EEH testing files are missing. Is debugfs mounted?" 57 53 exit $KSELFTESTS_SKIP; 58 54 fi 59 55 ··· 65 61 eeh_can_break() { 66 62 # skip bridges since we can't recover them (yet...) 67 63 if [ -e "/sys/bus/pci/devices/$dev/pci_bus" ] ; then 68 - echo "$dev, Skipped: bridge" 64 + log "$dev, Skipped: bridge" 69 65 return 1; 70 66 fi 71 67 ··· 74 70 # it the system will generally go down. We should probably fix that 75 71 # at some point 76 72 if [ "ahci" = "$(basename $(realpath /sys/bus/pci/devices/$dev/driver))" ] ; then 77 - echo "$dev, Skipped: ahci doesn't support recovery" 73 + log "$dev, Skipped: ahci doesn't support recovery" 78 74 return 1; 79 75 fi 80 76 ··· 84 80 # result in the recovery failing and the device being marked as 85 81 # failed. 86 82 if ! pe_ok $dev ; then 87 - echo "$dev, Skipped: Bad initial PE state" 83 + log "$dev, Skipped: Bad initial PE state" 88 84 return 1; 89 85 fi 90 86 ··· 98 94 # testing so check that the argument is a well-formed sysfs device 99 95 # name. 100 96 if ! test -e /sys/bus/pci/devices/$dev/ ; then 101 - echo "Error: '$dev' must be a sysfs device name (DDDD:BB:DD.F)" 97 + log "Error: '$dev' must be a sysfs device name (DDDD:BB:DD.F)" 102 98 return 1; 103 99 fi 104 100 ··· 122 118 if pe_ok $dev ; then 123 119 break; 124 120 fi 125 - echo "$dev, waited $i/${max_wait}" 121 + log "$dev, waited $i/${max_wait}" 126 122 sleep 1 127 123 done 128 124 129 125 if ! pe_ok $dev ; then 130 - echo "$dev, Failed to recover!" 126 + log "$dev, Failed to recover!" 131 127 return 1; 132 128 fi 133 129 134 - echo "$dev, Recovered after $i seconds" 130 + log "$dev, Recovered after $i seconds" 135 131 return 0; 136 132 } 137 133