Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARM: sa1100: explicitly register sa11x0-pcmcia devices

Simplify the code by getting rid of the conditional automatic
registration of the sa11x0 PCMCIA interfaces in sa1100_init(), and
require all platforms to explicitly call sa11x0_register_pcmcia().
Only one platform (iPAQ) is affected by this change.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

+1 -10
-10
arch/arm/mach-sa1100/generic.c
··· 235 235 sa11x0_register_device(&sa11x0fb_device, inf); 236 236 } 237 237 238 - static bool sa11x0pcmcia_legacy = true; 239 - static struct platform_device sa11x0pcmcia_device = { 240 - .name = "sa11x0-pcmcia", 241 - .id = -1, 242 - }; 243 - 244 238 void sa11x0_register_pcmcia(int socket, struct gpiod_lookup_table *table) 245 239 { 246 240 if (table) 247 241 gpiod_add_lookup_table(table); 248 242 platform_device_register_simple("sa11x0-pcmcia", socket, NULL, 0); 249 - sa11x0pcmcia_legacy = false; 250 243 } 251 244 252 245 static struct platform_device sa11x0mtd_device = { ··· 323 330 static int __init sa1100_init(void) 324 331 { 325 332 pm_power_off = sa1100_power_off; 326 - 327 - if (sa11x0pcmcia_legacy) 328 - platform_device_register(&sa11x0pcmcia_device); 329 333 330 334 regulator_has_full_constraints(); 331 335
+1
arch/arm/mach-sa1100/h3100.c
··· 126 126 { 127 127 h3xxx_mach_init(); 128 128 129 + sa11x0_register_pcmcia(-1, NULL); 129 130 sa11x0_register_lcd(&h3100_lcd_info); 130 131 sa11x0_register_irda(&h3100_irda_data); 131 132 }