Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rapidio: devices: fix missing put_device in mport_cdev_open

When kfifo_alloc fails, the refcount of chdev->dev is left incremental.
We should use put_device(&chdev->dev) to decrease the ref count of
chdev->dev to avoid refcount leak.

Link: https://lkml.kernel.org/r/20221203085721.13146-1-caixinchen1@huawei.com
Fixes: e8de370188d0 ("rapidio: add mport char device driver")
Signed-off-by: Cai Xinchen <caixinchen1@huawei.com>
Cc: Alexandre Bounine <alex.bou9@gmail.com>
Cc: Dan Carpenter <error27@gmail.com>
Cc: Jakob Koschel <jakobkoschel@gmail.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Wang Weiyang <wangweiyang2@huawei.com>
Cc: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Cai Xinchen and committed by
Andrew Morton
d5b6e6eb 204c2f53

+1
+1
drivers/rapidio/devices/rio_mport_cdev.c
··· 1912 1912 sizeof(struct rio_event) * MPORT_EVENT_DEPTH, 1913 1913 GFP_KERNEL); 1914 1914 if (ret < 0) { 1915 + put_device(&chdev->dev); 1915 1916 dev_err(&chdev->dev, DRV_NAME ": kfifo_alloc failed\n"); 1916 1917 ret = -ENOMEM; 1917 1918 goto err_fifo;