Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

powerpc+of: Rename and fix OF reconfig notifier error inject module

This module used to inject errors in the pSeries specific dynamic
reconfiguration notifiers. Those are gone however, replaced by
generic notifiers for changes to the device-tree. So let's update
the module to deal with these instead and rename it along the way.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Akinobu Mita <akinobu.mita@gmail.com>

+18 -18
+5 -5
lib/Kconfig.debug
··· 1192 1192 1193 1193 If unsure, say N. 1194 1194 1195 - config PSERIES_RECONFIG_NOTIFIER_ERROR_INJECT 1196 - tristate "pSeries reconfig notifier error injection module" 1197 - depends on PPC_PSERIES && NOTIFIER_ERROR_INJECTION 1195 + config OF_RECONFIG_NOTIFIER_ERROR_INJECT 1196 + tristate "OF reconfig notifier error injection module" 1197 + depends on OF_DYNAMIC && NOTIFIER_ERROR_INJECTION 1198 1198 help 1199 1199 This option provides the ability to inject artifical errors to 1200 - pSeries reconfig notifier chain callbacks. It is controlled 1200 + OF reconfig notifier chain callbacks. It is controlled 1201 1201 through debugfs interface under 1202 - /sys/kernel/debug/notifier-error-inject/pSeries-reconfig/ 1202 + /sys/kernel/debug/notifier-error-inject/OF-reconfig/ 1203 1203 1204 1204 If the notifier call chain should be failed with some events 1205 1205 notified, write the error code to "actions/<notifier event>/error".
+2 -2
lib/Makefile
··· 94 94 obj-$(CONFIG_CPU_NOTIFIER_ERROR_INJECT) += cpu-notifier-error-inject.o 95 95 obj-$(CONFIG_PM_NOTIFIER_ERROR_INJECT) += pm-notifier-error-inject.o 96 96 obj-$(CONFIG_MEMORY_NOTIFIER_ERROR_INJECT) += memory-notifier-error-inject.o 97 - obj-$(CONFIG_PSERIES_RECONFIG_NOTIFIER_ERROR_INJECT) += \ 98 - pSeries-reconfig-notifier-error-inject.o 97 + obj-$(CONFIG_OF_RECONFIG_NOTIFIER_ERROR_INJECT) += \ 98 + of-reconfig-notifier-error-inject.o 99 99 100 100 lib-$(CONFIG_GENERIC_BUG) += bug.o 101 101
+11 -11
lib/pSeries-reconfig-notifier-error-inject.c lib/of-reconfig-notifier-error-inject.c
··· 1 1 #include <linux/kernel.h> 2 2 #include <linux/module.h> 3 - 4 - #include <asm/pSeries_reconfig.h> 3 + #include <linux/of.h> 5 4 6 5 #include "notifier-error-inject.h" 7 6 8 7 static int priority; 9 8 module_param(priority, int, 0); 10 - MODULE_PARM_DESC(priority, "specify pSeries reconfig notifier priority"); 9 + MODULE_PARM_DESC(priority, "specify OF reconfig notifier priority"); 11 10 12 11 static struct notifier_err_inject reconfig_err_inject = { 13 12 .actions = { 14 - { NOTIFIER_ERR_INJECT_ACTION(PSERIES_RECONFIG_ADD) }, 15 - { NOTIFIER_ERR_INJECT_ACTION(PSERIES_RECONFIG_REMOVE) }, 16 - { NOTIFIER_ERR_INJECT_ACTION(PSERIES_DRCONF_MEM_ADD) }, 17 - { NOTIFIER_ERR_INJECT_ACTION(PSERIES_DRCONF_MEM_REMOVE) }, 13 + { NOTIFIER_ERR_INJECT_ACTION(OF_RECONFIG_ATTACH_NODE) }, 14 + { NOTIFIER_ERR_INJECT_ACTION(OF_RECONFIG_DETACH_NODE) }, 15 + { NOTIFIER_ERR_INJECT_ACTION(OF_RECONFIG_ADD_PROPERTY) }, 16 + { NOTIFIER_ERR_INJECT_ACTION(OF_RECONFIG_REMOVE_PROPERTY) }, 17 + { NOTIFIER_ERR_INJECT_ACTION(OF_RECONFIG_UPDATE_PROPERTY) }, 18 18 {} 19 19 } 20 20 }; ··· 25 25 { 26 26 int err; 27 27 28 - dir = notifier_err_inject_init("pSeries-reconfig", 28 + dir = notifier_err_inject_init("OF-reconfig", 29 29 notifier_err_inject_dir, &reconfig_err_inject, priority); 30 30 if (IS_ERR(dir)) 31 31 return PTR_ERR(dir); 32 32 33 - err = pSeries_reconfig_notifier_register(&reconfig_err_inject.nb); 33 + err = of_reconfig_notifier_register(&reconfig_err_inject.nb); 34 34 if (err) 35 35 debugfs_remove_recursive(dir); 36 36 ··· 39 39 40 40 static void err_inject_exit(void) 41 41 { 42 - pSeries_reconfig_notifier_unregister(&reconfig_err_inject.nb); 42 + of_reconfig_notifier_unregister(&reconfig_err_inject.nb); 43 43 debugfs_remove_recursive(dir); 44 44 } 45 45 46 46 module_init(err_inject_init); 47 47 module_exit(err_inject_exit); 48 48 49 - MODULE_DESCRIPTION("pSeries reconfig notifier error injection module"); 49 + MODULE_DESCRIPTION("OF reconfig notifier error injection module"); 50 50 MODULE_LICENSE("GPL"); 51 51 MODULE_AUTHOR("Akinobu Mita <akinobu.mita@gmail.com>");