Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

firmware-gsmi: Delete an unnecessary check before the function call "dma_pool_destroy"

The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Cc: Mike Waychison <mikew@google.com>
Cc: Michel Lespinasse <walken@google.com>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>

authored by

Markus Elfring and committed by
Matt Fleming
d520dd1f ac0e94b6

+1 -2
+1 -2
drivers/firmware/google/gsmi.c
··· 910 910 gsmi_buf_free(gsmi_dev.param_buf); 911 911 gsmi_buf_free(gsmi_dev.data_buf); 912 912 gsmi_buf_free(gsmi_dev.name_buf); 913 - if (gsmi_dev.dma_pool) 914 - dma_pool_destroy(gsmi_dev.dma_pool); 913 + dma_pool_destroy(gsmi_dev.dma_pool); 915 914 platform_device_unregister(gsmi_dev.pdev); 916 915 pr_info("gsmi: failed to load: %d\n", ret); 917 916 return ret;