tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

i2c: mt65xx: convert set_speed function to void

cppcheck rightfully reports:
drivers/i2c/busses/i2c-mt65xx.c:1464:6: warning: Condition 'ret' is always false [knownConditionTrueFalse]

Make the function void and simplify the code.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Wolfram Sang d51e7cfc b71a6e2a

+2 -9
+2 -9
drivers/i2c/busses/i2c-mt65xx.c
··· 868 868 return 0; 869 869 } 870 870 871 - static int mtk_i2c_set_speed(struct mtk_i2c *i2c, unsigned int parent_clk) 871 + static void mtk_i2c_set_speed(struct mtk_i2c *i2c, unsigned int parent_clk) 872 872 { 873 873 unsigned int clk_src; 874 874 unsigned int step_cnt; ··· 938 938 939 939 break; 940 940 } 941 - 942 - 943 - return 0; 944 941 } 945 942 946 943 static void i2c_dump_register(struct mtk_i2c *i2c) ··· 1457 1460 1458 1461 strscpy(i2c->adap.name, I2C_DRV_NAME, sizeof(i2c->adap.name)); 1459 1462 1460 - ret = mtk_i2c_set_speed(i2c, clk_get_rate(i2c->clocks[speed_clk].clk)); 1461 - if (ret) { 1462 - dev_err(&pdev->dev, "Failed to set the speed.\n"); 1463 - return -EINVAL; 1464 - } 1463 + mtk_i2c_set_speed(i2c, clk_get_rate(i2c->clocks[speed_clk].clk)); 1465 1464 1466 1465 if (i2c->dev_comp->max_dma_support > 32) { 1467 1466 ret = dma_set_mask(&pdev->dev,