Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging:iio:triggers: rename iio-trig-gpio to iio-trig-interrupt

Also change all internal naming appropriately.
This trigger is no longer just for gpio provided interrupts so
change the naming to reflect this. Also drop some now missleading
left over comments.

Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>

+31 -45
+4 -4
drivers/staging/iio/trigger/Kconfig
··· 12 12 Provides support for using periodic capable real time 13 13 clocks as IIO triggers. 14 14 15 - config IIO_GPIO_TRIGGER 16 - tristate "GPIO trigger" 17 - depends on GPIOLIB 15 + config IIO_INTERRUPT_TRIGGER 16 + tristate "Generic interrupt trigger" 18 17 help 19 - Provides support for using GPIO pins as IIO triggers. 18 + Provides support for using interrupts of various types as IIO 19 + triggers. These may be provided by a gpio driver for example. 20 20 21 21 config IIO_BFIN_TMR_TRIGGER 22 22 tristate "Blackfin TIMER trigger"
+1 -1
drivers/staging/iio/trigger/Makefile
··· 3 3 # 4 4 5 5 obj-$(CONFIG_IIO_PERIODIC_RTC_TRIGGER) += iio-trig-periodic-rtc.o 6 - obj-$(CONFIG_IIO_GPIO_TRIGGER) += iio-trig-gpio.o 6 + obj-$(CONFIG_IIO_INTERRUPT_TRIGGER) += iio-trig-interrupt.o 7 7 obj-$(CONFIG_IIO_BFIN_TMR_TRIGGER) += iio-trig-bfin-timer.o
+26 -40
drivers/staging/iio/trigger/iio-trig-gpio.c drivers/staging/iio/trigger/iio-trig-interrupt.c
··· 1 1 /* 2 - * Industrial I/O - gpio based trigger support 2 + * Industrial I/O - generic interrupt based trigger support 3 3 * 4 - * Copyright (c) 2008 Jonathan Cameron 4 + * Copyright (c) 2008-2013 Jonathan Cameron 5 5 * 6 6 * This program is free software; you can redistribute it and/or modify it 7 7 * under the terms of the GNU General Public License version 2 as published by 8 8 * the Free Software Foundation. 9 - * 10 - * Currently this is more of a functioning proof of concept than a full 11 - * fledged trigger driver. 12 - * 13 - * TODO: 14 - * 15 - * Add board config elements to allow specification of startup settings. 16 9 */ 17 10 18 11 #include <linux/kernel.h> ··· 17 24 #include <linux/iio/iio.h> 18 25 #include <linux/iio/trigger.h> 19 26 20 - static LIST_HEAD(iio_gpio_trigger_list); 21 - static DEFINE_MUTEX(iio_gpio_trigger_list_lock); 27 + static LIST_HEAD(iio_interrupt_trigger_list); 28 + static DEFINE_MUTEX(iio_interrupt_trigger_list_lock); 22 29 23 - struct iio_gpio_trigger_info { 30 + struct iio_interrupt_trigger_info { 24 31 struct mutex in_use; 25 32 unsigned int irq; 26 33 }; 27 - /* 28 - * Need to reference count these triggers and only enable gpio interrupts 29 - * as appropriate. 30 - */ 31 34 32 - /* So what functionality do we want in here?... */ 33 - /* set high / low as interrupt type? */ 34 - 35 - static irqreturn_t iio_gpio_trigger_poll(int irq, void *private) 35 + static irqreturn_t iio_interrupt_trigger_poll(int irq, void *private) 36 36 { 37 37 /* Timestamp not currently provided */ 38 38 iio_trigger_poll(private, 0); 39 39 return IRQ_HANDLED; 40 40 } 41 41 42 - static const struct iio_trigger_ops iio_gpio_trigger_ops = { 42 + static const struct iio_trigger_ops iio_interrupt_trigger_ops = { 43 43 .owner = THIS_MODULE, 44 44 }; 45 45 46 - static int iio_gpio_trigger_probe(struct platform_device *pdev) 46 + static int iio_interrupt_trigger_probe(struct platform_device *pdev) 47 47 { 48 - struct iio_gpio_trigger_info *trig_info; 48 + struct iio_interrupt_trigger_info *trig_info; 49 49 struct iio_trigger *trig, *trig2; 50 50 unsigned long irqflags; 51 51 struct resource *irq_res; ··· 50 64 51 65 if (irq_res == NULL) { 52 66 if (irq_res_cnt == 0) 53 - dev_err(&pdev->dev, "No GPIO IRQs specified"); 67 + dev_err(&pdev->dev, "No IRQs specified"); 54 68 break; 55 69 } 56 70 irqflags = (irq_res->flags & IRQF_TRIGGER_MASK) | IRQF_SHARED; ··· 70 84 } 71 85 iio_trigger_set_drvdata(trig, trig_info); 72 86 trig_info->irq = irq; 73 - trig->ops = &iio_gpio_trigger_ops; 74 - ret = request_irq(irq, iio_gpio_trigger_poll, 87 + trig->ops = &iio_interrupt_trigger_ops; 88 + ret = request_irq(irq, iio_interrupt_trigger_poll, 75 89 irqflags, trig->name, trig); 76 90 if (ret) { 77 91 dev_err(&pdev->dev, ··· 84 98 goto error_release_irq; 85 99 86 100 list_add_tail(&trig->alloc_list, 87 - &iio_gpio_trigger_list); 101 + &iio_interrupt_trigger_list); 88 102 } 89 103 90 104 irq_res_cnt++; ··· 101 115 error_put_trigger: 102 116 iio_trigger_put(trig); 103 117 error_free_completed_registrations: 104 - /* The rest should have been added to the iio_gpio_trigger_list */ 118 + /* The rest should have been added to the iio_interrupt_trigger_list */ 105 119 list_for_each_entry_safe(trig, 106 120 trig2, 107 - &iio_gpio_trigger_list, 121 + &iio_interrupt_trigger_list, 108 122 alloc_list) { 109 123 trig_info = iio_trigger_get_drvdata(trig); 110 124 free_irq(trig_info->irq, trig); ··· 115 129 return ret; 116 130 } 117 131 118 - static int iio_gpio_trigger_remove(struct platform_device *pdev) 132 + static int iio_interrupt_trigger_remove(struct platform_device *pdev) 119 133 { 120 134 struct iio_trigger *trig, *trig2; 121 - struct iio_gpio_trigger_info *trig_info; 135 + struct iio_interrupt_trigger_info *trig_info; 122 136 123 - mutex_lock(&iio_gpio_trigger_list_lock); 137 + mutex_lock(&iio_interrupt_trigger_list_lock); 124 138 list_for_each_entry_safe(trig, 125 139 trig2, 126 - &iio_gpio_trigger_list, 140 + &iio_interrupt_trigger_list, 127 141 alloc_list) { 128 142 trig_info = iio_trigger_get_drvdata(trig); 129 143 iio_trigger_unregister(trig); ··· 131 145 kfree(trig_info); 132 146 iio_trigger_put(trig); 133 147 } 134 - mutex_unlock(&iio_gpio_trigger_list_lock); 148 + mutex_unlock(&iio_interrupt_trigger_list_lock); 135 149 136 150 return 0; 137 151 } 138 152 139 - static struct platform_driver iio_gpio_trigger_driver = { 140 - .probe = iio_gpio_trigger_probe, 141 - .remove = iio_gpio_trigger_remove, 153 + static struct platform_driver iio_interrupt_trigger_driver = { 154 + .probe = iio_interrupt_trigger_probe, 155 + .remove = iio_interrupt_trigger_remove, 142 156 .driver = { 143 - .name = "iio_gpio_trigger", 157 + .name = "iio_interrupt_trigger", 144 158 .owner = THIS_MODULE, 145 159 }, 146 160 }; 147 161 148 - module_platform_driver(iio_gpio_trigger_driver); 162 + module_platform_driver(iio_interrupt_trigger_driver); 149 163 150 164 MODULE_AUTHOR("Jonathan Cameron <jic23@kernel.org>"); 151 - MODULE_DESCRIPTION("Example gpio trigger for the iio subsystem"); 165 + MODULE_DESCRIPTION("Interrupt trigger for the iio subsystem"); 152 166 MODULE_LICENSE("GPL v2");