Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

regmap-i2c: Use i2c block command only if register value width is 8 bit

Chips with 16-bit registers don't usually work well with I2C block
commands. For example, neither the LM75 datasheet nor the TMP102 datasheet
mentions block command support, and in fact it does not work for any of
those chips. Also, it is not clear how the block command would handle
16-bit SMBus operations in the fist place, since the data format associated
with those commands is either little endian or big endian, which requires
some kind of conversion to or from host byte order.

Only use i2c block commands if both register and value width is 8 bit.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Guenter Roeck and committed by
Mark Brown
d4ef9306 1a695a90

+1 -1
+1 -1
drivers/base/regmap/regmap-i2c.c
··· 259 259 { 260 260 if (i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C)) 261 261 return &regmap_i2c; 262 - else if (config->reg_bits == 8 && 262 + else if (config->val_bits == 8 && config->reg_bits == 8 && 263 263 i2c_check_functionality(i2c->adapter, 264 264 I2C_FUNC_SMBUS_I2C_BLOCK)) 265 265 return &regmap_i2c_smbus_i2c_block;